Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in transform checker #6770

Closed
overlookmotel opened this issue Oct 22, 2024 · 2 comments
Closed

Possible bug in transform checker #6770

overlookmotel opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Comments

@overlookmotel
Copy link
Contributor

#6658 threw up some semantic errors which look like they could be erroneous.

* async-to-generator/shadowed-promise-import/input.mjs
Bindings mismatch:
after transform: ScopeId(0): ["Promise", "_foo", "foo"]
rebuilt : ScopeId(3): []

Why is ScopeId(0) being mapped to ScopeId(3)?

This could be a bug in the transform checker.

@overlookmotel overlookmotel added C-bug Category - Bug A-transformer Area - Transformer / Transpiler labels Oct 22, 2024
@overlookmotel overlookmotel self-assigned this Oct 22, 2024
@Dunqing
Copy link
Member

Dunqing commented Oct 22, 2024

I have resolved many semantic errors at #6658. Now, the remaining errors are related to this problem. I don't know the SemanticChecker how to check, since I moved a scope to a new scope, it is correct that the scope ID does not match. However, if it checks its child scopes, it can prove that even though the scope ID mismatch, they are still correct.

@Dunqing
Copy link
Member

Dunqing commented Oct 22, 2024

I have corrected all semantic errors so close it because there is no bug in the transform checker.

@Dunqing Dunqing closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

No branches or pull requests

2 participants