From 926bb1fed77d19483b61ca5a676f92582b7fa09a Mon Sep 17 00:00:00 2001
From: Sysix <sysix@sysix-coding.de>
Date: Tue, 7 Jan 2025 18:52:29 +0100
Subject: [PATCH 1/2] refactor(linter): split `unicorn/prefer-spread` and
 `eslint/prefer-spread` into own rules

---
 crates/oxc_linter/src/rules.rs                |   2 +
 .../src/rules/eslint/prefer_spread.rs         | 454 +----------
 .../src/rules/unicorn/prefer_spread.rs        | 473 +++++++++++
 .../src/snapshots/eslint_prefer_spread.snap   | 763 ------------------
 4 files changed, 479 insertions(+), 1213 deletions(-)
 create mode 100644 crates/oxc_linter/src/rules/unicorn/prefer_spread.rs

diff --git a/crates/oxc_linter/src/rules.rs b/crates/oxc_linter/src/rules.rs
index 9fae5f8eaeb23..fc7e7383b400d 100644
--- a/crates/oxc_linter/src/rules.rs
+++ b/crates/oxc_linter/src/rules.rs
@@ -379,6 +379,7 @@ mod unicorn {
     pub mod prefer_regexp_test;
     pub mod prefer_set_has;
     pub mod prefer_set_size;
+    pub mod prefer_spread;
     pub mod prefer_string_raw;
     pub mod prefer_string_replace_all;
     pub mod prefer_string_slice;
@@ -955,6 +956,7 @@ oxc_macros::declare_all_lint_rules! {
     unicorn::no_zero_fractions,
     unicorn::number_literal_case,
     unicorn::numeric_separators_style,
+    unicorn::prefer_spread,
     unicorn::prefer_add_event_listener,
     unicorn::prefer_array_flat,
     unicorn::prefer_array_flat_map,
diff --git a/crates/oxc_linter/src/rules/eslint/prefer_spread.rs b/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
index b91dac4895148..3fd8084ba8ac1 100644
--- a/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
+++ b/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
@@ -1,38 +1,23 @@
-use cow_utils::CowUtils;
 use oxc_ast::{
     ast::{match_member_expression, CallExpression, ChainElement, Expression, MemberExpression},
     AstKind,
 };
 use oxc_diagnostics::OxcDiagnostic;
 use oxc_macros::declare_oxc_lint;
-use oxc_span::{cmp::ContentEq, GetSpan, Span};
-use phf::phf_set;
+use oxc_span::{cmp::ContentEq, Span};
 
-use crate::{
-    ast_util::{self, is_method_call},
-    context::LintContext,
-    rule::Rule,
-    AstNode,
-};
+use crate::{ast_util::is_method_call, context::LintContext, rule::Rule, AstNode};
 
 fn eslint_prefer_spread_diagnostic(span: Span) -> OxcDiagnostic {
     OxcDiagnostic::warn("Require spread operators instead of .apply()").with_label(span)
 }
 
-fn unicorn_prefer_spread_diagnostic(span: Span, bad_method: &str) -> OxcDiagnostic {
-    OxcDiagnostic::warn(format!("Prefer the spread operator (`...`) over {bad_method}"))
-        .with_help("The spread operator (`...`) is more concise and readable.")
-        .with_label(span)
-}
-
 #[derive(Debug, Default, Clone)]
 pub struct PreferSpread;
 
 declare_oxc_lint!(
     /// This rule is combined 2 rules from `eslint:prefer-spread` and `unicorn:prefer-spread`.
     ///
-    /// ## original eslint:prefer-spread
-    ///
     /// ### What it does
     ///
     /// Require spread operators instead of .apply()
@@ -77,33 +62,8 @@ declare_oxc_lint!(
     /// foo.apply(null, [1, 2, 3]);
     /// obj.foo.apply(obj, [1, 2, 3]);
     /// ```
-    ///
-    /// ## unicorn:prefer-spread
-    ///
-    /// ### What it does
-    ///
-    /// Enforces the use of [the spread operator (`...`)](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax) over outdated patterns.
-    ///
-    /// ### Why is this bad?
-    ///
-    /// Using the spread operator is more concise and readable.
-    ///
-    /// ### Examples
-    ///
-    /// Examples of **incorrect** code for this rule:
-    /// ```javascript
-    /// const foo = Array.from(set);
-    /// const foo = Array.from(new Set([1, 2]));
-    /// ```
-    ///
-    /// Examples of **correct** code for this rule:
-    /// ```javascript
-    /// [...set].map(() => {});
-    /// Array.from(...argumentsArray);
-    /// ```
     PreferSpread,
-    style,
-    conditional_fix
+    style
 );
 
 impl Rule for PreferSpread {
@@ -113,7 +73,6 @@ impl Rule for PreferSpread {
         };
 
         check_eslint_prefer_spread(call_expr, ctx);
-        check_unicorn_prefer_spread(call_expr, ctx);
     }
 }
 
@@ -186,191 +145,6 @@ fn as_member_expression_without_chain_expression<'a>(
     }
 }
 
-fn check_unicorn_prefer_spread(call_expr: &CallExpression, ctx: &LintContext) {
-    let Some(member_expr) = call_expr.callee.without_parentheses().as_member_expression() else {
-        return;
-    };
-
-    let Some(static_property_name) = member_expr.static_property_name() else {
-        return;
-    };
-
-    match static_property_name {
-        // `Array.from()`
-        "from" => {
-            if call_expr.arguments.len() != 1 || member_expr.is_computed() {
-                return;
-            }
-
-            let Some(expr) = call_expr.arguments[0].as_expression() else {
-                return;
-            };
-            if matches!(expr.without_parentheses(), Expression::ObjectExpression(_)) {
-                return;
-            }
-
-            let Expression::Identifier(ident) = member_expr.object().without_parentheses() else {
-                return;
-            };
-
-            if ident.name != "Array" {
-                return;
-            }
-
-            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "Array.from()"));
-        }
-        // `array.concat()`
-        "concat" => {
-            if is_not_array(member_expr.object().without_parentheses(), ctx) {
-                return;
-            }
-
-            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.concat()"));
-        }
-        // `array.slice()`
-        "slice" => {
-            if call_expr.arguments.len() > 1 {
-                return;
-            }
-
-            let member_expr_obj = member_expr.object().without_parentheses();
-
-            if matches!(
-                member_expr_obj,
-                Expression::ArrayExpression(_) | Expression::ThisExpression(_)
-            ) {
-                return;
-            }
-
-            if let Expression::Identifier(ident) = member_expr_obj {
-                if IGNORED_SLICE_CALLEE.contains(ident.name.as_str()) {
-                    return;
-                }
-            }
-
-            if let Some(first_arg) = call_expr.arguments.first() {
-                let Some(first_arg) = first_arg.as_expression() else {
-                    return;
-                };
-                if let Expression::NumericLiteral(num_lit) = first_arg.without_parentheses() {
-                    if num_lit.value != 0.0 {
-                        return;
-                    }
-                } else {
-                    return;
-                }
-            }
-
-            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.slice()"));
-        }
-        // `array.toSpliced()`
-        "toSpliced" => {
-            if call_expr.arguments.len() != 0 {
-                return;
-            }
-
-            if matches!(member_expr.object().without_parentheses(), Expression::ArrayExpression(_))
-            {
-                return;
-            }
-
-            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.toSpliced()"));
-        }
-        // `string.split()`
-        "split" => {
-            if call_expr.arguments.len() != 1 {
-                return;
-            }
-
-            let Some(expr) = call_expr.arguments[0].as_expression() else {
-                return;
-            };
-            let Expression::StringLiteral(string_lit) = expr.without_parentheses() else {
-                return;
-            };
-
-            if string_lit.value != "" {
-                return;
-            }
-
-            ctx.diagnostic_with_fix(
-                unicorn_prefer_spread_diagnostic(call_expr.span, "string.split()"),
-                |fixer| {
-                    let callee_obj = member_expr.object().without_parentheses();
-                    fixer.replace(
-                        call_expr.span,
-                        format!("[...{}]", callee_obj.span().source_text(ctx.source_text())),
-                    )
-                },
-            );
-        }
-        _ => {}
-    }
-}
-
-const IGNORED_SLICE_CALLEE: phf::Set<&'static str> = phf_set! {
-    "arrayBuffer",
-    "blob",
-    "buffer",
-    "file",
-    "this",
-};
-
-fn is_not_array(expr: &Expression, ctx: &LintContext) -> bool {
-    if matches!(
-        expr.without_parentheses(),
-        Expression::TemplateLiteral(_) | Expression::BinaryExpression(_)
-    ) {
-        return true;
-    }
-    if expr.is_literal() {
-        return true;
-    }
-
-    if let Expression::CallExpression(call_expr) = expr {
-        if let Some(member_expr) = call_expr.callee.without_parentheses().as_member_expression() {
-            if Some("join") == member_expr.static_property_name() && call_expr.arguments.len() < 2 {
-                return true;
-            }
-            return false;
-        }
-        return false;
-    }
-
-    let ident = match expr.without_parentheses() {
-        Expression::Identifier(ident) => {
-            if let Some(symbol_id) = ast_util::get_symbol_id_of_variable(ident, ctx) {
-                let symbol_table = ctx.semantic().symbols();
-                let node = ctx.nodes().get_node(symbol_table.get_declaration(symbol_id));
-
-                if let AstKind::VariableDeclarator(variable_declarator) = node.kind() {
-                    if let Some(ref_expr) = &variable_declarator.init {
-                        return is_not_array(ref_expr, ctx);
-                    }
-                }
-            }
-
-            ident.name.as_str()
-        }
-        expr @ match_member_expression!(Expression) => {
-            if let Some(v) = expr.to_member_expression().static_property_name() {
-                v
-            } else {
-                return false;
-            }
-        }
-        _ => return false,
-    };
-
-    if ident.starts_with(|c: char| c.is_ascii_uppercase())
-        && ident.cow_to_ascii_uppercase() != ident
-    {
-        return true;
-    }
-
-    false
-}
-
 #[test]
 fn test() {
     use crate::tester::Tester;
@@ -392,111 +166,9 @@ fn test() {
         "(a?.b).c.foo.apply(a?.b.c, args);",
         "a?.b.c.foo.apply((a?.b).c, args);",
         "class C { #apply; foo() { foo.#apply(undefined, args); } }",
-        /* Test cases for unicorn:prefer-spread */
-        r"[...set].map(() => {});",
-        r"Int8Array.from(set);",
-        r"Uint8Array.from(set);",
-        r"Uint8ClampedArray.from(set);",
-        r"Int16Array.from(set);",
-        r"Uint16Array.from(set);",
-        r"Int32Array.from(set);",
-        r"Uint32Array.from(set);",
-        r"Float32Array.from(set);",
-        r"Float64Array.from(set);",
-        r"BigInt64Array.from(set);",
-        r"BigUint64Array.from(set);",
-        r"new Array.from(foo);",
-        r"from(foo);",
-        r#"Array["from"](foo);"#,
-        r"Array[from](foo);",
-        r"Array.foo(foo);",
-        r"foo.from(foo);",
-        r"lib.Array.from(foo);",
-        r"Array.from();",
-        r"Array.from(foo, mapFn, thisArg, extra);",
-        r"Array.from(...argumentsArray);",
-        r"Array.from(set, mapFn).reduce(() => {});",
-        r"Array.from(set, mapFn, thisArg).reduce(() => {});",
-        r"Array.from(set, () => {}, thisArg).reduce(() => {});",
-        r"Array.from({length: 10});",
-        r"new Array.concat(1)",
-        r"concat(1)",
-        r"array[concat](1)",
-        r#""foo".concat("bar")"#,
-        r#"`${foo}`.concat("bar")"#,
-        r"const bufA = Buffer.concat([buf1, buf2, buf3], totalLength);",
-        r"Foo.concat(1)",
-        r"FooBar.concat(1)",
-        r"global.Buffer.concat([])",
-        r#"["1", "2"].join(",").concat("...")"#,
-        r#"foo.join(",").concat("...")"#,
-        r"foo.join().concat(bar)",
-        // r#"(a + b).concat(c)"#,
-        r"new Array.slice()",
-        r"slice()",
-        r"array[slice]()",
-        r"array.slice",
-        r"array.slice(1)",
-        r"array.slice(...[])",
-        r"array.slice(...[0])",
-        r"array.slice(0 + 0)",
-        r#"array.slice("")"#,
-        r"array.slice(null)",
-        r"const ZERO = 0;array.slice(ZERO)",
-        r"array.slice(0, array.length)",
-        r"array.slice(0, 0)",
-        r"array.notSlice()",
-        r"[...foo].slice()",
-        r"[foo].slice()",
-        r"arrayBuffer.slice()",
-        r"blob.slice()",
-        r"buffer.slice()",
-        r"file.slice()",
-        r"class A {foo() {this.slice()}}",
-        r"new Array.toSpliced()",
-        r"toSpliced()",
-        r"array[toSpliced]()",
-        r"array.toSpliced",
-        r"array.toSpliced(0)",
-        r"array.toSpliced(...[])",
-        r"array.toSpliced(...[0])",
-        r"array.toSpliced(0 + 0)",
-        r#"array.toSpliced("")"#,
-        r"array.toSpliced(null)",
-        r"const ZERO = 0;array.toSpliced(0, ZERO)",
-        r"array.toSpliced(0, array.length)",
-        r"array.toSpliced(0, 0)",
-        r"array.notToSpliced()",
-        r"[...foo].toSpliced()",
-        r"[foo].toSpliced()",
-        r"array.toSpliced(100, 0)",
-        r"array.toSpliced(-1, 0)",
-        r#"new foo.split("")"#,
-        r#"split("")"#,
-        r#"string[split]("")"#,
-        r"string.split",
-        r"string.split(1)",
-        r#"string.split(..."")"#,
-        r#"string.split(...[""])"#,
-        r#"string.split("" + "")"#,
-        r"string.split(0)",
-        r"string.split(false)",
-        r"string.split(undefined)",
-        r"string.split(0n)",
-        r"string.split(null)",
-        r#"string.split(/""/)"#,
-        r"string.split(``)",
-        r#"const EMPTY_STRING = ""; string.split(EMPTY_STRING)"#,
-        r#"string.split("", limit)"#,
-        r#""".split(string)"#,
-        r"string.split()",
-        r#"string.notSplit("")"#,
-        r#"const x = "foo"; x.concat(x);"#,
-        r#"const y = "foo"; const x = y; x.concat(x);"#,
     ];
 
     let fail = vec![
-        /* Test cases for original eslint:prefer-spread */
         "foo.apply(undefined, args);",
         "foo.apply(void 0, args);",
         "foo.apply(null, args);",
@@ -517,125 +189,7 @@ fn test() {
         "(a?.b.c).foo.apply(a?.b.c, args);",
         "(a?.b).c.foo.apply((a?.b).c, args);",
         "class C { #foo; foo() { obj.#foo.apply(obj, args); } }",
-        /* Test cases for unicorn:prefer-spread */
-        r"const x = Array.from(set);",
-        r"Array.from(set).map(() => {});",
-        r"Array.from(new Set([1, 2])).map(() => {});",
-        r#"Array.from(document.querySelectorAll("*")).map(() => {});"#,
-        r"const foo = `${Array.from(arrayLike)}`",
-        r"(Array).from(foo)",
-        r"(Array.from)(foo)",
-        r"((Array).from)(foo)",
-        r"(Array).from((0, foo))",
-        r"(Array.from)((0, foo))",
-        r"((Array).from)((0, foo))",
-        r"Array.from(a ? b : c)",
-        r"Array.from([...a, ...b], )",
-        r"Array.from([1])",
-        r"Array.from([...a, ...b])",
-        r"/* 1 */ Array /* 2 */ .from /* 3 */ ( /* 4 */ a /* 5 */,)",
-        r"[1].concat(2)",
-        r"[1].concat([2, 3])",
-        r"[1].concat(2,)",
-        r"[1].concat([2, ...bar],)",
-        r"[1,].concat(2)",
-        r"[1,].concat([2, 3])",
-        r"[1,].concat(2,)",
-        r"[1,].concat([2, 3],)",
-        r"(( (( (( [1,] )).concat ))( (([2, 3])) ,) ))",
-        r"(( (( (( [1,] )).concat ))( (([2, 3])) , bar ) ))",
-        r"foo.concat(2)",
-        r"foo.concat([2, 3])",
-        r"foo.concat(2,)",
-        r"foo.concat([2, 3],)",
-        r"(( (( ((foo)).concat ))( (([2, 3])) ,) ))",
-        r"(( (( ((foo)).concat ))( (([2, 3])) , bar ) ))",
-        r"const foo = foo.concat(2)",
-        r"const foo = () => foo.concat(2)",
-        r"foo.concat([bar])",
-        r"foo.concat(bar)",
-        r"Array.from(set).concat([2, 3])",
-        r"foo.concat([2, 3]).concat(4)",
-        r#"string.concat("bar")"#,
-        r"foo.concat(2, 3)",
-        r"foo.concat(2, bar)",
-        r"[...foo, 2].concat(bar)",
-        r"let sortedScores = scores.concat().sort((a, b) => b[0] - a[0]);",
-        r"foo.concat(bar, 2, 3)",
-        r"foo.concat(bar, 2, 3, baz)",
-        r"async function a() {return [].concat(await bar)}",
-        r"async function a() {return [].concat(((await bar)))}",
-        r"foo.concat((0, 1))",
-        r"async function a() {return (await bar).concat(1)}",
-        r"[].concat(...bar)",
-        r"[].concat([,], [])",
-        r"[,].concat([,], [,])",
-        r"[,].concat([,,], [,])",
-        r"[,].concat([,], [,,])",
-        r"[1].concat([2,], [3,])",
-        r"[1].concat([2,,], [3,,])",
-        r"[1,].concat([2,], [3,])",
-        r"[1,].concat([2,,], [3,,])",
-        r"[].concat([], [])",
-        r"[].concat((a.b.c), 2)",
-        r"[].concat(a.b(), 2)",
-        r"foo.concat(bar, 2, [3, 4], baz, 5, [6, 7])",
-        r"foo.concat(bar, 2, 3, ...baz)",
-        r"notClass.concat(1)",
-        r"_A.concat(1)",
-        r"FOO.concat(1)",
-        r"A.concat(1)",
-        r"Foo.x.concat(1)",
-        r"if (test) foo.concat(1)",
-        r"if (test) {} else foo.concat(1)",
-        r"if (test) {} else foo.concat(1)",
-        r"for (;;) foo.concat(1)",
-        r"for (a in b) foo.concat(1)",
-        r"for (a in b) foo.concat(1)",
-        r"for (const a of b) foo.concat(1)",
-        r"while (test) foo.concat(1)",
-        r"do foo.concat(1); while (test)",
-        r"with (foo) foo.concat(1)",
-        r#"foo.join(foo, bar).concat("...")"#,
-        r"array.slice()",
-        r"array.slice().slice()",
-        r"array.slice(1).slice()",
-        r"array.slice().slice(1)",
-        r"const copy = array.slice()",
-        r"(( (( (( array )).slice ))() ))",
-        r#""".slice()"#,
-        r"new Uint8Array([10, 20, 30, 40, 50]).slice()",
-        r"array.slice(0)",
-        r"array.slice(0b0)",
-        r"array.slice(0.00)",
-        r"array.slice(0.00, )",
-        r"array.toSpliced()",
-        r"array.toSpliced().toSpliced()",
-        r"const copy = array.toSpliced()",
-        r"(( (( (( array )).toSpliced ))() ))",
-        r#""".toSpliced()"#,
-        r"new Uint8Array([10, 20, 30, 40, 50]).toSpliced()",
-        r#""string".split("")"#,
-        r#""string".split('')"#,
-        r#"unknown.split("")"#,
-        r#"const characters = "string".split("")"#,
-        r#"(( (( (( "string" )).split ))( (("")) ) ))"#,
-        r#"unknown.split("")"#,
-        r#""🦄".split("")"#,
-        r#"const {length} = "🦄".split("")"#,
-    ];
-
-    let expect_fix = vec![
-        /* Test cases for unicorn:prefer-spread */
-        // `Array.from()`
-        // `array.slice()`
-        // `array.toSpliced()`
-        // `string.split()`
-        (r#""🦄".split("")"#, r#"[..."🦄"]"#, None),
-        (r#""foo bar baz".split("")"#, r#"[..."foo bar baz"]"#, None),
     ];
 
-    Tester::new(PreferSpread::NAME, PreferSpread::CATEGORY, pass, fail)
-        .expect_fix(expect_fix)
-        .test_and_snapshot();
+    Tester::new(PreferSpread::NAME, PreferSpread::CATEGORY, pass, fail).test_and_snapshot();
 }
diff --git a/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs b/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
new file mode 100644
index 0000000000000..bd9f7ae8fc83b
--- /dev/null
+++ b/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
@@ -0,0 +1,473 @@
+use cow_utils::CowUtils;
+use oxc_ast::{
+    ast::{match_member_expression, CallExpression, Expression},
+    AstKind,
+};
+use oxc_diagnostics::OxcDiagnostic;
+use oxc_macros::declare_oxc_lint;
+use oxc_span::{GetSpan, Span};
+use phf::phf_set;
+
+use crate::{ast_util, context::LintContext, rule::Rule, AstNode};
+
+fn unicorn_prefer_spread_diagnostic(span: Span, bad_method: &str) -> OxcDiagnostic {
+    OxcDiagnostic::warn(format!("Prefer the spread operator (`...`) over {bad_method}"))
+        .with_help("The spread operator (`...`) is more concise and readable.")
+        .with_label(span)
+}
+
+#[derive(Debug, Default, Clone)]
+pub struct PreferSpread;
+
+declare_oxc_lint!(
+    /// ### What it does
+    ///
+    /// Enforces the use of [the spread operator (`...`)](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax) over outdated patterns.
+    ///
+    /// ### Why is this bad?
+    ///
+    /// Using the spread operator is more concise and readable.
+    ///
+    /// ### Examples
+    ///
+    /// Examples of **incorrect** code for this rule:
+    /// ```javascript
+    /// const foo = Array.from(set);
+    /// const foo = Array.from(new Set([1, 2]));
+    /// ```
+    ///
+    /// Examples of **correct** code for this rule:
+    /// ```javascript
+    /// [...set].map(() => {});
+    /// Array.from(...argumentsArray);
+    /// ```
+    PreferSpread,
+    style,
+    conditional_fix
+);
+
+impl Rule for PreferSpread {
+    fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
+        let AstKind::CallExpression(call_expr) = node.kind() else {
+            return;
+        };
+
+        println!("{call_expr:?}");
+
+        check_unicorn_prefer_spread(call_expr, ctx);
+    }
+}
+
+fn check_unicorn_prefer_spread(call_expr: &CallExpression, ctx: &LintContext) {
+    let Some(member_expr) = call_expr.callee.without_parentheses().as_member_expression() else {
+        return;
+    };
+
+    let Some(static_property_name) = member_expr.static_property_name() else {
+        return;
+    };
+
+    match static_property_name {
+        // `Array.from()`
+        "from" => {
+            if call_expr.arguments.len() != 1 || member_expr.is_computed() {
+                return;
+            }
+
+            let Some(expr) = call_expr.arguments[0].as_expression() else {
+                return;
+            };
+            if matches!(expr.without_parentheses(), Expression::ObjectExpression(_)) {
+                return;
+            }
+
+            let Expression::Identifier(ident) = member_expr.object().without_parentheses() else {
+                return;
+            };
+
+            if ident.name != "Array" {
+                return;
+            }
+
+            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "Array.from()"));
+        }
+        // `array.concat()`
+        "concat" => {
+            if is_not_array(member_expr.object().without_parentheses(), ctx) {
+                return;
+            }
+
+            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.concat()"));
+        }
+        // `array.slice()`
+        "slice" => {
+            if call_expr.arguments.len() > 1 {
+                return;
+            }
+
+            let member_expr_obj = member_expr.object().without_parentheses();
+
+            if matches!(
+                member_expr_obj,
+                Expression::ArrayExpression(_) | Expression::ThisExpression(_)
+            ) {
+                return;
+            }
+
+            if let Expression::Identifier(ident) = member_expr_obj {
+                if IGNORED_SLICE_CALLEE.contains(ident.name.as_str()) {
+                    return;
+                }
+            }
+
+            if let Some(first_arg) = call_expr.arguments.first() {
+                let Some(first_arg) = first_arg.as_expression() else {
+                    return;
+                };
+                if let Expression::NumericLiteral(num_lit) = first_arg.without_parentheses() {
+                    if num_lit.value != 0.0 {
+                        return;
+                    }
+                } else {
+                    return;
+                }
+            }
+
+            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.slice()"));
+        }
+        // `array.toSpliced()`
+        "toSpliced" => {
+            if call_expr.arguments.len() != 0 {
+                return;
+            }
+
+            if matches!(member_expr.object().without_parentheses(), Expression::ArrayExpression(_))
+            {
+                return;
+            }
+
+            ctx.diagnostic(unicorn_prefer_spread_diagnostic(call_expr.span, "array.toSpliced()"));
+        }
+        // `string.split()`
+        "split" => {
+            if call_expr.arguments.len() != 1 {
+                return;
+            }
+
+            let Some(expr) = call_expr.arguments[0].as_expression() else {
+                return;
+            };
+            let Expression::StringLiteral(string_lit) = expr.without_parentheses() else {
+                return;
+            };
+
+            if string_lit.value != "" {
+                return;
+            }
+
+            ctx.diagnostic_with_fix(
+                unicorn_prefer_spread_diagnostic(call_expr.span, "string.split()"),
+                |fixer| {
+                    let callee_obj = member_expr.object().without_parentheses();
+                    fixer.replace(
+                        call_expr.span,
+                        format!("[...{}]", callee_obj.span().source_text(ctx.source_text())),
+                    )
+                },
+            );
+        }
+        _ => {}
+    }
+}
+
+const IGNORED_SLICE_CALLEE: phf::Set<&'static str> = phf_set! {
+    "arrayBuffer",
+    "blob",
+    "buffer",
+    "file",
+    "this",
+};
+
+fn is_not_array(expr: &Expression, ctx: &LintContext) -> bool {
+    if matches!(
+        expr.without_parentheses(),
+        Expression::TemplateLiteral(_) | Expression::BinaryExpression(_)
+    ) {
+        return true;
+    }
+    if expr.is_literal() {
+        return true;
+    }
+
+    if let Expression::CallExpression(call_expr) = expr {
+        if let Some(member_expr) = call_expr.callee.without_parentheses().as_member_expression() {
+            if Some("join") == member_expr.static_property_name() && call_expr.arguments.len() < 2 {
+                return true;
+            }
+            return false;
+        }
+        return false;
+    }
+
+    let ident = match expr.without_parentheses() {
+        Expression::Identifier(ident) => {
+            if let Some(symbol_id) = ast_util::get_symbol_id_of_variable(ident, ctx) {
+                let symbol_table = ctx.semantic().symbols();
+                let node = ctx.nodes().get_node(symbol_table.get_declaration(symbol_id));
+
+                if let AstKind::VariableDeclarator(variable_declarator) = node.kind() {
+                    if let Some(ref_expr) = &variable_declarator.init {
+                        return is_not_array(ref_expr, ctx);
+                    }
+                }
+            }
+
+            ident.name.as_str()
+        }
+        expr @ match_member_expression!(Expression) => {
+            if let Some(v) = expr.to_member_expression().static_property_name() {
+                v
+            } else {
+                return false;
+            }
+        }
+        _ => return false,
+    };
+
+    if ident.starts_with(|c: char| c.is_ascii_uppercase())
+        && ident.cow_to_ascii_uppercase() != ident
+    {
+        return true;
+    }
+
+    false
+}
+
+#[test]
+fn test() {
+    use crate::tester::Tester;
+
+    let pass = vec![
+        r"[...set].map(() => {});",
+        r"Int8Array.from(set);",
+        r"Uint8Array.from(set);",
+        r"Uint8ClampedArray.from(set);",
+        r"Int16Array.from(set);",
+        r"Uint16Array.from(set);",
+        r"Int32Array.from(set);",
+        r"Uint32Array.from(set);",
+        r"Float32Array.from(set);",
+        r"Float64Array.from(set);",
+        r"BigInt64Array.from(set);",
+        r"BigUint64Array.from(set);",
+        r"new Array.from(foo);",
+        r"from(foo);",
+        r#"Array["from"](foo);"#,
+        r"Array[from](foo);",
+        r"Array.foo(foo);",
+        r"foo.from(foo);",
+        r"lib.Array.from(foo);",
+        r"Array.from();",
+        r"Array.from(foo, mapFn, thisArg, extra);",
+        r"Array.from(...argumentsArray);",
+        r"Array.from(set, mapFn).reduce(() => {});",
+        r"Array.from(set, mapFn, thisArg).reduce(() => {});",
+        r"Array.from(set, () => {}, thisArg).reduce(() => {});",
+        r"Array.from({length: 10});",
+        r"new Array.concat(1)",
+        r"concat(1)",
+        r"array[concat](1)",
+        r#""foo".concat("bar")"#,
+        r#"`${foo}`.concat("bar")"#,
+        r"const bufA = Buffer.concat([buf1, buf2, buf3], totalLength);",
+        r"Foo.concat(1)",
+        r"FooBar.concat(1)",
+        r"global.Buffer.concat([])",
+        r#"["1", "2"].join(",").concat("...")"#,
+        r#"foo.join(",").concat("...")"#,
+        r"foo.join().concat(bar)",
+        // r#"(a + b).concat(c)"#,
+        r"new Array.slice()",
+        r"slice()",
+        r"array[slice]()",
+        r"array.slice",
+        r"array.slice(1)",
+        r"array.slice(...[])",
+        r"array.slice(...[0])",
+        r"array.slice(0 + 0)",
+        r#"array.slice("")"#,
+        r"array.slice(null)",
+        r"const ZERO = 0;array.slice(ZERO)",
+        r"array.slice(0, array.length)",
+        r"array.slice(0, 0)",
+        r"array.notSlice()",
+        r"[...foo].slice()",
+        r"[foo].slice()",
+        r"arrayBuffer.slice()",
+        r"blob.slice()",
+        r"buffer.slice()",
+        r"file.slice()",
+        r"class A {foo() {this.slice()}}",
+        r"new Array.toSpliced()",
+        r"toSpliced()",
+        r"array[toSpliced]()",
+        r"array.toSpliced",
+        r"array.toSpliced(0)",
+        r"array.toSpliced(...[])",
+        r"array.toSpliced(...[0])",
+        r"array.toSpliced(0 + 0)",
+        r#"array.toSpliced("")"#,
+        r"array.toSpliced(null)",
+        r"const ZERO = 0;array.toSpliced(0, ZERO)",
+        r"array.toSpliced(0, array.length)",
+        r"array.toSpliced(0, 0)",
+        r"array.notToSpliced()",
+        r"[...foo].toSpliced()",
+        r"[foo].toSpliced()",
+        r"array.toSpliced(100, 0)",
+        r"array.toSpliced(-1, 0)",
+        r#"new foo.split("")"#,
+        r#"split("")"#,
+        r#"string[split]("")"#,
+        r"string.split",
+        r"string.split(1)",
+        r#"string.split(..."")"#,
+        r#"string.split(...[""])"#,
+        r#"string.split("" + "")"#,
+        r"string.split(0)",
+        r"string.split(false)",
+        r"string.split(undefined)",
+        r"string.split(0n)",
+        r"string.split(null)",
+        r#"string.split(/""/)"#,
+        r"string.split(``)",
+        r#"const EMPTY_STRING = ""; string.split(EMPTY_STRING)"#,
+        r#"string.split("", limit)"#,
+        r#""".split(string)"#,
+        r"string.split()",
+        r#"string.notSplit("")"#,
+        r#"const x = "foo"; x.concat(x);"#,
+        r#"const y = "foo"; const x = y; x.concat(x);"#,
+    ];
+
+    let fail = vec![
+        r"const x = Array.from(set);",
+        r"Array.from(set).map(() => {});",
+        r"Array.from(new Set([1, 2])).map(() => {});",
+        r#"Array.from(document.querySelectorAll("*")).map(() => {});"#,
+        r"const foo = `${Array.from(arrayLike)}`",
+        r"(Array).from(foo)",
+        r"(Array.from)(foo)",
+        r"((Array).from)(foo)",
+        r"(Array).from((0, foo))",
+        r"(Array.from)((0, foo))",
+        r"((Array).from)((0, foo))",
+        r"Array.from(a ? b : c)",
+        r"Array.from([...a, ...b], )",
+        r"Array.from([1])",
+        r"Array.from([...a, ...b])",
+        r"/* 1 */ Array /* 2 */ .from /* 3 */ ( /* 4 */ a /* 5 */,)",
+        r"[1].concat(2)",
+        r"[1].concat([2, 3])",
+        r"[1].concat(2,)",
+        r"[1].concat([2, ...bar],)",
+        r"[1,].concat(2)",
+        r"[1,].concat([2, 3])",
+        r"[1,].concat(2,)",
+        r"[1,].concat([2, 3],)",
+        r"(( (( (( [1,] )).concat ))( (([2, 3])) ,) ))",
+        r"(( (( (( [1,] )).concat ))( (([2, 3])) , bar ) ))",
+        r"foo.concat(2)",
+        r"foo.concat([2, 3])",
+        r"foo.concat(2,)",
+        r"foo.concat([2, 3],)",
+        r"(( (( ((foo)).concat ))( (([2, 3])) ,) ))",
+        r"(( (( ((foo)).concat ))( (([2, 3])) , bar ) ))",
+        r"const foo = foo.concat(2)",
+        r"const foo = () => foo.concat(2)",
+        r"foo.concat([bar])",
+        r"foo.concat(bar)",
+        r"Array.from(set).concat([2, 3])",
+        r"foo.concat([2, 3]).concat(4)",
+        r#"string.concat("bar")"#,
+        r"foo.concat(2, 3)",
+        r"foo.concat(2, bar)",
+        r"[...foo, 2].concat(bar)",
+        r"let sortedScores = scores.concat().sort((a, b) => b[0] - a[0]);",
+        r"foo.concat(bar, 2, 3)",
+        r"foo.concat(bar, 2, 3, baz)",
+        r"async function a() {return [].concat(await bar)}",
+        r"async function a() {return [].concat(((await bar)))}",
+        r"foo.concat((0, 1))",
+        r"async function a() {return (await bar).concat(1)}",
+        r"[].concat(...bar)",
+        r"[].concat([,], [])",
+        r"[,].concat([,], [,])",
+        r"[,].concat([,,], [,])",
+        r"[,].concat([,], [,,])",
+        r"[1].concat([2,], [3,])",
+        r"[1].concat([2,,], [3,,])",
+        r"[1,].concat([2,], [3,])",
+        r"[1,].concat([2,,], [3,,])",
+        r"[].concat([], [])",
+        r"[].concat((a.b.c), 2)",
+        r"[].concat(a.b(), 2)",
+        r"foo.concat(bar, 2, [3, 4], baz, 5, [6, 7])",
+        r"foo.concat(bar, 2, 3, ...baz)",
+        r"notClass.concat(1)",
+        r"_A.concat(1)",
+        r"FOO.concat(1)",
+        r"A.concat(1)",
+        r"Foo.x.concat(1)",
+        r"if (test) foo.concat(1)",
+        r"if (test) {} else foo.concat(1)",
+        r"if (test) {} else foo.concat(1)",
+        r"for (;;) foo.concat(1)",
+        r"for (a in b) foo.concat(1)",
+        r"for (a in b) foo.concat(1)",
+        r"for (const a of b) foo.concat(1)",
+        r"while (test) foo.concat(1)",
+        r"do foo.concat(1); while (test)",
+        r"with (foo) foo.concat(1)",
+        r#"foo.join(foo, bar).concat("...")"#,
+        r"array.slice()",
+        r"array.slice().slice()",
+        r"array.slice(1).slice()",
+        r"array.slice().slice(1)",
+        r"const copy = array.slice()",
+        r"(( (( (( array )).slice ))() ))",
+        r#""".slice()"#,
+        r"new Uint8Array([10, 20, 30, 40, 50]).slice()",
+        r"array.slice(0)",
+        r"array.slice(0b0)",
+        r"array.slice(0.00)",
+        r"array.slice(0.00, )",
+        r"array.toSpliced()",
+        r"array.toSpliced().toSpliced()",
+        r"const copy = array.toSpliced()",
+        r"(( (( (( array )).toSpliced ))() ))",
+        r#""".toSpliced()"#,
+        r"new Uint8Array([10, 20, 30, 40, 50]).toSpliced()",
+        r#""string".split("")"#,
+        r#""string".split('')"#,
+        r#"unknown.split("")"#,
+        r#"const characters = "string".split("")"#,
+        r#"(( (( (( "string" )).split ))( (("")) ) ))"#,
+        r#"unknown.split("")"#,
+        r#""🦄".split("")"#,
+        r#"const {length} = "🦄".split("")"#,
+    ];
+
+    let expect_fix = vec![
+        // `Array.from()`
+        // `array.slice()`
+        // `array.toSpliced()`
+        // `string.split()`
+        (r#""🦄".split("")"#, r#"[..."🦄"]"#, None),
+        (r#""foo bar baz".split("")"#, r#"[..."foo bar baz"]"#, None),
+    ];
+
+    Tester::new(PreferSpread::NAME, PreferSpread::CATEGORY, pass, fail)
+        .expect_fix(expect_fix)
+        .test_and_snapshot();
+}
diff --git a/crates/oxc_linter/src/snapshots/eslint_prefer_spread.snap b/crates/oxc_linter/src/snapshots/eslint_prefer_spread.snap
index dc2fa8ed0aa9c..c06611e35faa7 100644
--- a/crates/oxc_linter/src/snapshots/eslint_prefer_spread.snap
+++ b/crates/oxc_linter/src/snapshots/eslint_prefer_spread.snap
@@ -110,766 +110,3 @@ snapshot_kind: text
  1 │ class C { #foo; foo() { obj.#foo.apply(obj, args); } }
    ·                         ─────────────────────────
    ╰────
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:11]
- 1 │ const x = Array.from(set);
-   ·           ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(set).map(() => {});
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(new Set([1, 2])).map(() => {});
-   · ───────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(document.querySelectorAll("*")).map(() => {});
-   · ──────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:16]
- 1 │ const foo = `${Array.from(arrayLike)}`
-   ·                ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ (Array).from(foo)
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ (Array.from)(foo)
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ ((Array).from)(foo)
-   · ───────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ (Array).from((0, foo))
-   · ──────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ (Array.from)((0, foo))
-   · ──────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ ((Array).from)((0, foo))
-   · ────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(a ? b : c)
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from([...a, ...b], )
-   · ──────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from([1])
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from([...a, ...b])
-   · ────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:9]
- 1 │ /* 1 */ Array /* 2 */ .from /* 3 */ ( /* 4 */ a /* 5 */,)
-   ·         ─────────────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat(2)
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat([2, 3])
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat(2,)
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat([2, ...bar],)
-   · ────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat(2)
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat([2, 3])
-   · ───────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat(2,)
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat([2, 3],)
-   · ────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( (( [1,] )).concat ))( (([2, 3])) ,) ))
-   ·    ──────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( (( [1,] )).concat ))( (([2, 3])) , bar ) ))
-   ·    ───────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(2)
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat([2, 3])
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(2,)
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat([2, 3],)
-   · ───────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( ((foo)).concat ))( (([2, 3])) ,) ))
-   ·    ───────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( ((foo)).concat ))( (([2, 3])) , bar ) ))
-   ·    ────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:13]
- 1 │ const foo = foo.concat(2)
-   ·             ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:19]
- 1 │ const foo = () => foo.concat(2)
-   ·                   ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat([bar])
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(bar)
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(set).concat([2, 3])
-   · ──────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over Array.from()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Array.from(set).concat([2, 3])
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat([2, 3]).concat(4)
-   · ────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat([2, 3]).concat(4)
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ string.concat("bar")
-   · ────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(2, 3)
-   · ────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(2, bar)
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [...foo, 2].concat(bar)
-   · ───────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:20]
- 1 │ let sortedScores = scores.concat().sort((a, b) => b[0] - a[0]);
-   ·                    ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(bar, 2, 3)
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(bar, 2, 3, baz)
-   · ──────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:28]
- 1 │ async function a() {return [].concat(await bar)}
-   ·                            ────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:28]
- 1 │ async function a() {return [].concat(((await bar)))}
-   ·                            ────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat((0, 1))
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:28]
- 1 │ async function a() {return (await bar).concat(1)}
-   ·                            ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [].concat(...bar)
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [].concat([,], [])
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [,].concat([,], [,])
-   · ────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [,].concat([,,], [,])
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [,].concat([,], [,,])
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat([2,], [3,])
-   · ──────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1].concat([2,,], [3,,])
-   · ────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat([2,], [3,])
-   · ───────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [1,].concat([2,,], [3,,])
-   · ─────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [].concat([], [])
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [].concat((a.b.c), 2)
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ [].concat(a.b(), 2)
-   · ───────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(bar, 2, [3, 4], baz, 5, [6, 7])
-   · ──────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.concat(bar, 2, 3, ...baz)
-   · ─────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ notClass.concat(1)
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ _A.concat(1)
-   · ────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ FOO.concat(1)
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ A.concat(1)
-   · ───────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ Foo.x.concat(1)
-   · ───────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:11]
- 1 │ if (test) foo.concat(1)
-   ·           ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:19]
- 1 │ if (test) {} else foo.concat(1)
-   ·                   ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:19]
- 1 │ if (test) {} else foo.concat(1)
-   ·                   ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:10]
- 1 │ for (;;) foo.concat(1)
-   ·          ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:14]
- 1 │ for (a in b) foo.concat(1)
-   ·              ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:14]
- 1 │ for (a in b) foo.concat(1)
-   ·              ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:20]
- 1 │ for (const a of b) foo.concat(1)
-   ·                    ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:14]
- 1 │ while (test) foo.concat(1)
-   ·              ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ do foo.concat(1); while (test)
-   ·    ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:12]
- 1 │ with (foo) foo.concat(1)
-   ·            ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.concat()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ foo.join(foo, bar).concat("...")
-   · ────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice()
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice().slice()
-   · ─────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice().slice()
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice(1).slice()
-   · ──────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice().slice(1)
-   · ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:14]
- 1 │ const copy = array.slice()
-   ·              ─────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( (( array )).slice ))() ))
-   ·    ─────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ "".slice()
-   · ──────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ new Uint8Array([10, 20, 30, 40, 50]).slice()
-   · ────────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice(0)
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice(0b0)
-   · ────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice(0.00)
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.slice()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.slice(0.00, )
-   · ───────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.toSpliced()
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.toSpliced().toSpliced()
-   · ─────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ array.toSpliced().toSpliced()
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:14]
- 1 │ const copy = array.toSpliced()
-   ·              ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( (( array )).toSpliced ))() ))
-   ·    ─────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ "".toSpliced()
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over array.toSpliced()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ new Uint8Array([10, 20, 30, 40, 50]).toSpliced()
-   · ────────────────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ "string".split("")
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ "string".split('')
-   · ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ unknown.split("")
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:20]
- 1 │ const characters = "string".split("")
-   ·                    ──────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:4]
- 1 │ (( (( (( "string" )).split ))( (("")) ) ))
-   ·    ────────────────────────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ unknown.split("")
-   · ─────────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:1]
- 1 │ "🦄".split("")
-   · ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.
-
-  ⚠ eslint(prefer-spread): Prefer the spread operator (`...`) over string.split()
-   ╭─[prefer_spread.tsx:1:18]
- 1 │ const {length} = "🦄".split("")
-   ·                  ──────────────
-   ╰────
-  help: The spread operator (`...`) is more concise and readable.

From 480a09177a10331fc759b1c927524bf457a59b30 Mon Sep 17 00:00:00 2001
From: Sysix <sysix@sysix-coding.de>
Date: Tue, 7 Jan 2025 19:10:16 +0100
Subject: [PATCH 2/2] refactor(linter): split unicorn/prefer-spread and
 eslint/prefer-spread into own rules

---
 crates/oxc_linter/src/rules/eslint/prefer_spread.rs  | 2 ++
 crates/oxc_linter/src/rules/unicorn/prefer_spread.rs | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/crates/oxc_linter/src/rules/eslint/prefer_spread.rs b/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
index 3fd8084ba8ac1..233d26127890b 100644
--- a/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
+++ b/crates/oxc_linter/src/rules/eslint/prefer_spread.rs
@@ -72,6 +72,8 @@ impl Rule for PreferSpread {
             return;
         };
 
+        println!("hello from eslint world");
+
         check_eslint_prefer_spread(call_expr, ctx);
     }
 }
diff --git a/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs b/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
index bd9f7ae8fc83b..1ca980b74dcdd 100644
--- a/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
+++ b/crates/oxc_linter/src/rules/unicorn/prefer_spread.rs
@@ -52,7 +52,7 @@ impl Rule for PreferSpread {
             return;
         };
 
-        println!("{call_expr:?}");
+        println!("hello from unicorn world");
 
         check_unicorn_prefer_spread(call_expr, ctx);
     }