Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reconfigurator] Builder API does not provide guarantees that datasets are provisioned for zones, but should #6990

Closed
2 tasks
smklein opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
bug Something that isn't working. Update System Replacing old bits with newer, cooler bits

Comments

@smklein
Copy link
Collaborator

smklein commented Nov 5, 2024

Today, if you use the planner to provision a new zone, it'll provision a new zone in the constructed blueprint, and then invoke sled_ensure_datasets, which will create necessary records for that zone to exist.

However, if you use the reconfigurator-cli to provision a new zone, it'll make a new zone in the blueprint, but it will be missing a corresponding dataset (see also: #6987 , where we could catch this!). I believe our live-tests are also suffering from the same defect.

This issue tracks two things:

  • We should patch these callsites, where zones are provisioned without datasets, to ensure that datasets are actually getting provisioned
  • We should update the API to the builder to make it harder to misuse - provisioning a new zone should likely immediately provision a corresponding dataset (or datasets).

FYI @jgallagher

@smklein smklein added bug Something that isn't working. Update System Replacing old bits with newer, cooler bits labels Nov 5, 2024
@jgallagher jgallagher self-assigned this Nov 5, 2024
@jgallagher
Copy link
Contributor

Fixed by #7105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working. Update System Replacing old bits with newer, cooler bits
Projects
None yet
Development

No branches or pull requests

2 participants