Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubling CI jobs issue for internal contributors #2377

Closed
nvuillam opened this issue Feb 19, 2023 · 5 comments
Closed

Doubling CI jobs issue for internal contributors #2377

nvuillam opened this issue Feb 19, 2023 · 5 comments
Labels
O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@nvuillam
Copy link
Member

We have 234 CI jobs, it's really too many and when there are several running PR workflows, it generates too much delay

I didn't succeed to configure Build Deploy DEV - Linters job to avoid it to be launched twice... if someone succeeds it it would really improve contributing experience :)

Another solution could be to add a condition to run individual linter checks, so they would be triggered only when we want it, for example if the commit text or PR text contains some word like check linters

image

image

@bdovaz
Copy link
Collaborator

bdovaz commented Feb 19, 2023

@nvuillam the culprit is me in #2294 but we really need a way to run the build+tests of each linter in parallel.

Until now it was only done with a very small subset fixed in the workflows and for me in that PR (#2294) it was super frustrating to have to wait for the task that builds all linters and runs all the tests together (Build MegaLinter Docker Image (full from main repo) and Run Test Cases) and wait half an hour or more for it to fail or not.... By running them in parallel at least it speeds up that process quite a bit....

@nvuillam
Copy link
Member Author

I know that, but the is no reason to run twice the same test for a single PR :)
And i still think that it should be "on demand": for example PRs from auto update linters job does not need to run all those checks

@echoix
Copy link
Collaborator

echoix commented Feb 21, 2023

I stumbled upon this, when I wasn't looking specifically for this https://github.com/fkirc/skip-duplicate-actions. I didn't make my opinion on it yet. But maybe we could try temporarily setting jobs.<job_id>.strategy.max-parallel a bit lower especially on jobs that run on main only (or releases), so we could have runners left for other things. (Once in main, it's not as urgent to have all 112 jobs to run as quickly as possible) https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymax-parallel

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 24, 2023
@nvuillam
Copy link
Member Author

I think I solved it, now the linter jobs are run just once as they are triggered only on pull_request, not push :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

3 participants