Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.20.0] Running on Mac m1 no longer working #2427

Closed
mikael-j-rich opened this issue Mar 6, 2023 · 13 comments · Fixed by #2430 · 4 remaining pull requests
Closed

[v6.20.0] Running on Mac m1 no longer working #2427

mikael-j-rich opened this issue Mar 6, 2023 · 13 comments · Fixed by #2430 · 4 remaining pull requests
Labels
bug Something isn't working

Comments

@mikael-j-rich
Copy link

Describe the bug
Been running the linter locally on my Mac m1 using Rosetta and the megalinter-runner script has been working fine. Since v6.20.0 the script fails saying "no matching manifest for linux/arm64/v8 in the manifest list entries".

To Reproduce
Steps to reproduce the behavior:

  1. Run npx megalinter-runner on Mac m1.

Expected behavior
I expect the image to be pulled and started on Docker.

@mikael-j-rich mikael-j-rich added the bug Something isn't working label Mar 6, 2023
@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

We changed the way to build docker images, it could be related...

As we don't provide (yet) arm64 images, it should probably be solvable adding --platform linux/x86_64/v8 to the docker pull

cf https://stackoverflow.com/a/67361161/7113625

@echoix
Copy link
Collaborator

echoix commented Mar 6, 2023

Was v6.19.0 built with buildx? @nvuillam

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

@echoix yes but it was raw buildx , not docker build github action, which is here only since 6.20.0

@echoix
Copy link
Collaborator

echoix commented Mar 6, 2023

Ok, that excludes one of my hypotheses. If we don't specify the platforms on the action, does it still build ?

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

Platforms are hardcoded in the action parameters.
So far only linux/amd64

image

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

@mikael-j-rich please could you try with npx megalinter-runner@beta and confirm it's ok ?

@timgentry
Copy link
Contributor

@nvuillam npx mega-linter-runner@beta worked for me, where npx mega-linter-runner was broken on an M1 Mac

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

@timgentry many thanks for your quick feedback !

@mikael-j-rich
Copy link
Author

@nvuillam Sorry for the delay on feedback, you were to quick! 😄

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

@nvuillam Sorry for the delay on feedback, you were to quick! 😄

@mikael-j-rich that's ok, it takes a whole community to fix a bug 😅

@VictorRos
Copy link
Contributor

Hello!
We are also using MegaLinter in our project.
Some of us use Intel chipsets while other use Apple Silicon M1 chipsets.
Do you have a due date for an official patch 6.20.1 that will include this fix?
This way, we will all use the same version to validate rules.
Best regards,
Victor

@nvuillam
Copy link
Member

nvuillam commented Mar 7, 2023

@VictorRos we are trying to solve other issues, but if we don't succeed very quick we'll release a first patch before
Probably tonight, hang on :)

@VictorRos
Copy link
Contributor

Ok, thank you for the quick answer!
Good luck with the other issues ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment