Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flavor cupcake is missing several linters #4364

Open
bdovaz opened this issue Dec 9, 2024 · 7 comments
Open

Flavor cupcake is missing several linters #4364

bdovaz opened this issue Dec 9, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@bdovaz
Copy link
Collaborator

bdovaz commented Dec 9, 2024

Is your feature request related to a problem? Please describe.

The flavor cupcake does not have the following linters:

https://megalinter.io/beta/flavors/cupcake/

POWERSHELL_POWERSHELL -> powershell is cross platform (windows/linux/macos) and in infrastructure scripts can be common to have bash or powershell scripts side by side
POWERSHELL_POWERSHELL_FORMATTER -> powershell is cross platform (windows/linux/macos) and in infrastructure scripts can be common to have bash or powershell scripts side by side
JSON_ESLINT_PLUGIN_JSONC -> I don't know why this one is not included when the rest of the json linters are included.
MARKDOWN_REMARK_LINT -> I don't know why this one doesn't include it when the rest of markdown linters is included
SPELL_VALE -> I don't know why this is not included when the rest of the spell linters are included.

Describe the solution you'd like

That the cupcake flavor include the following previously mentioned linters.

Describe alternatives you've considered

Use the all flavor

Additional context
Add any other context or screenshots about the feature request here.

cc @nvuillam @echoix

@bdovaz bdovaz added the enhancement New feature or request label Dec 9, 2024
@nvuillam
Copy link
Member

nvuillam commented Dec 9, 2024

@bdovaz some choices have been made to make the image smaller ^^ Are they optimal, it's obviously debatable ^^

  • remark-lint: it is disabled since 7 months because of Error: Cannot find module remark-preset-lint-recommended remarkjs/remark-lint#322. No one has talked about it yet until your issue :) Someday we should try to see how to reactivate it indeed

  • As far as I know, powershell is not that used in the linux world, probably why I did not include it in Cupcake

  • About the others, I don't really know... do you need them on some projects ? I'm not against adding them if you make a PR ^^

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 14, 2024

@bdovaz some choices have been made to make the image smaller ^^ Are they optimal, it's obviously debatable ^^

  • remark-lint: it is disabled since 7 months because of Error: Cannot find module remark-preset-lint-recommended remarkjs/remark-lint#322. No one has talked about it yet until your issue :) Someday we should try to see how to reactivate it indeed
  • As far as I know, powershell is not that used in the linux world, probably why I did not include it in Cupcake
  • About the others, I don't really know... do you need them on some projects ? I'm not against adding them if you make a PR ^^

Ok, checking a little bit, of all the ones I mentioned.

These are disabled by default, that's why cupcake doesn't include them:

  • JSON_ESLINT_PLUGIN_JSONC
  • MARKDOWN_REMARK_LINT

SPELL_VALE I don't know why it doesn`t include it honestly because it's not disabled: https://github.com/oxsecurity/megalinter/blob/main/megalinter/descriptors/spell.megalinter-descriptor.yml

@nvuillam I can create PR to add the 2 from powershell if you are ok with that and if you can tell me why it doesn't include the VALE linter we can fix that too.

@nvuillam
Copy link
Member

nvuillam commented Dec 14, 2024

@bdovaz ok, if the powershell linters are not too heavy ;)

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 14, 2024

@bdovaz ok, if the powershell linters are not too heavy ;)

@nvuillam what about VALE? You didn't answer to that.

Thanks.

@nvuillam
Copy link
Member

Go :)

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 15, 2024

Go :)

Please read my message about VALE...

@nvuillam
Copy link
Member

@bdovaz flavors are overridden at linter level, you can add cupcake there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants