Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guide #15

Closed
jnovick opened this issue Jan 31, 2019 · 5 comments
Closed

Add contribution guide #15

jnovick opened this issue Jan 31, 2019 · 5 comments
Labels
question Further information is requested

Comments

@jnovick
Copy link

jnovick commented Jan 31, 2019

Hey, I started creating a very similar extension, but before pushing to a git repository found your repo by looking at this issue: coverlet-coverage/coverlet#32. I figured instead of creating a competing project, I could contribute to yours. Unfortunately, I am having trouble getting your project to compile for me because of the coverlet.console package. I am looking for advice on contributing and how to get started. Should I be waiting until coverlet-coverage/coverlet#212 is resolved to contribute that way it is published publicly. I tried publishing it myself but had an issue since it is .net core not .net standard. Let me know how to get started with contributions. Thanks.

@p10tyr
Copy link
Owner

p10tyr commented Mar 25, 2019

Oh Hi. Yes sorry for late reply. I was busy with with real life.
That package is an "unofficial" package I made from the real source code. I have contacted the guy from Coverlet if I can publish it but he does not reply.

Currently I am hosting it privately- will need some work to go public

I am happy you would like to contribute. I hope its not too late. Please let me sort out a open PR I am not sure what I did last time and need to catch up

@p10tyr
Copy link
Owner

p10tyr commented Mar 26, 2019

I have added a public NuGet for Coverlet.Core that I will be using.
It is on my own decision to publish it.. if tonerdo changes his mind and does his own version I will pull this package and update accordingly

https://www.nuget.org/packages/piotrkula.coverlet.core/

@jnovick
Copy link
Author

jnovick commented Mar 26, 2019

Thanks, I am busy this week but I am gonna take a look this weekend and possibly put up a couple MRs if I can get it building now that the package is available.

@p10tyr
Copy link
Owner

p10tyr commented Mar 26, 2019

I am in process of trying to update my source to use that package. will update master once I get it compiling

@p10tyr p10tyr added the question Further information is requested label Mar 26, 2019
@p10tyr
Copy link
Owner

p10tyr commented Mar 28, 2019

I made a forked version of Coverlet.Core and published it under piotrkula.coverlet.core but I will update the reference in the project so this should not be a problem any more.

Also I forked the latest version of Coverlet.Core which has a few extra parameters it want on the constructor so it wont build straight away. This plugin will probably not benefit from any of those things and is just a line fix to get going again. Will PR that soon

I went to a machine I never used for developing PrestoCoverage and documented what I needed to do to get it running and made this quick guide. Should get you going.

https://github.com/ppumkin/PrestoCoverage/wiki

@p10tyr p10tyr closed this as completed Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants