Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA Digest extern small notes #507

Open
jafingerhut opened this issue Dec 1, 2017 · 2 comments
Open

PSA Digest extern small notes #507

jafingerhut opened this issue Dec 1, 2017 · 2 comments

Comments

@jafingerhut
Copy link
Collaborator

Consider adding a note that an optional enhancement would be to maintain 'drop counts' for each Digest extern instance, that counted how many times a P4 program called the method to send a digest, but there was no room to store it, because driver and/or other software was not draining the memory used to store digests quickly enough.

Perhaps the second idea here would be best as a future PSA addition, but having the option in a Digest extern instance to eliminate duplicates would be useful, e.g. if it was a digest used for indicating that a source MAC address was not present in a MAC table, there is often no need to send duplicate messages to the control plane if multiple packets arriving near in time to each other send the same data in the digest.

@jafingerhut
Copy link
Collaborator Author

At least the 'drop count' portion of this issue is addressed in this PR: #558

@jafingerhut
Copy link
Collaborator Author

Leaving this issue open as a possible future enhancement to the PSA spec: the idea of standardizing an option for a Digest that makes it 'de-duplicating'. This is something that some switch ASICs do today for MAC learn notifications, for example -- if a burst of them occur near the same time, the hardware and/or driver software avoid storing duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants