Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for key=value pairs in annotations #605

Closed
mihaibudiu opened this issue Mar 27, 2018 · 3 comments
Closed

Add support for key=value pairs in annotations #605

mihaibudiu opened this issue Mar 27, 2018 · 3 comments
Labels

Comments

@mihaibudiu
Copy link
Contributor

This would enable annotations like

@pkginfo(name="my package", date="2018/3/29", version=2)
@ChrisDodd
Copy link
Contributor

duplicate of #99 ?

@mihaibudiu
Copy link
Contributor Author

Seems to be. But the key=value part does not seem to be implemented...
So we should probably reopen that.

@ChrisDodd
Copy link
Contributor

ChrisDodd commented Mar 27, 2018

IIRC at the time it was decided that full java-style identifier = expression annotations were not needed. But they should be relatively easy to add; the main concern is not impacting existing uses of simple expression annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants