add function for adding assignees to issues #589
Conversation
|
Build failed.
|
KPostOffice
force-pushed
the
add_assignee
branch
2 times, most recently
from
40d1945 to
7e8c07b
Compare
|
Build failed.
|
|
Build failed.
|
There was a problem hiding this comment.
Thanks for the PR, the code looks really good!
Regarding the tests, the code looks good but we need to generate the yaml files with the responses.
- As you might know from the contribution guide, If you run the tests locally, you need to provide github/gitlab/pagure tokens via env.var. and run the tests. This will touch the real services and save the responses to the yaml files. Those files need to be committed as well so we don't need to use secrets and touch the real services in CI. (Basically, it records the communication and removes the sensitive values.)
- Since it touches the real services, your account need to have the permissions to do assigning -- e.g. on GitHub, I can give you
triagepermission if you want. - I can also generate the response files for you. (I understand it's tricky for the first time.)
Thanks!
|
@lachmanfrantisek Do I just use my own personal access tokens for github/gitlab/pagure? |
@KPostOffice yes, but I think you need write access to the repository to set assignees... I think there is some test I have created before that used user-agnostic repository... lemme have a look... |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build succeeded.
|
|
@lachmanfrantisek PTAL |
ogr/services/gitlab/issue.py
Outdated
| a = self._raw_issue.__dict__.get("assignee_ids") or [] | ||
| for assignee in assignees: | ||
| users = self.project.service.gitlab_instance.users.list( # type: ignore | ||
| username=assignee | ||
| ) | ||
| if not users: | ||
| raise GitlabAPIException(f"Unable to find '{assignee}' username") | ||
| uid = str(users[0].id) | ||
| if uid not in a: | ||
| a.append(str(users[0].id)) | ||
|
|
||
| self._raw_issue.assignee_ids = a |
There was a problem hiding this comment.
Can we have a better name for the assignee list, please?
KPostOffice
force-pushed
the
add_assignee
branch
2 times, most recently
from
92b74b0 to
7f04a00
Compare
|
Build succeeded.
|
|
@lachmanfrantisek I addressed both comments. It should push on top of master nicely now. |
|
Build failed (gate pipeline).
|
lachmanfrantisek
force-pushed
the
add_assignee
branch
from
7f04a00 to
89c5e9b
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Closes: #586