supported more actions #363
Conversation
packit/schema.py
Outdated
| @@ -52,7 +52,8 @@ | |||
| "actions": { | |||
| "type": "object", | |||
| "properties": { | |||
| a: {"type": "string"} for a in ActionName.get_possible_values() | |||
| a: {"type": "array", "items": {"type": "string"}} | |||
There was a problem hiding this comment.
This means that we would no longer support action as a string, only as a list of strings, which means that we would break compatibility which would be really frustrating for our users.
Please make it work that the old way, providing a string for an action, would still be acceptable.
Example:
diff --git a/.packit.yaml b/.packit.yaml
index 4bde3dd..db587a7 100644
--- a/.packit.yaml
+++ b/.packit.yaml
@@ -32,3 +32,7 @@ jobs:
- fedora-29-x86_64
- fedora-rawhide-x86_64
- fedora-30-x86_64
+actions:
+ post-upstream-clone: "ls -lha"
+ pre-sync:
+ - "ls -lha"Failed validating 'type' in schema['properties']['actions']['properties']['post-upstream-clone']:
{'items': {'type': 'string'}, 'type': 'array'}
On instance['actions']['post-upstream-clone']:
'ls -lha'..
ERROR Cannot parse package config: Provided configuration is not valid: 'ls -lha' is not of type 'array'
Failed validating 'type' in schema['properties']['actions']['properties']['post-upstream-clone']:
{'items': {'type': 'string'}, 'type': 'array'}
|
Franta would tell this needs a rebase, you're 35 commits behind master ;) |
|
The rpm-build failure can be ignored. It fails only in rawhide due to |
There was a problem hiding this comment.
I just realized we miss one significant thing here: documentation. Could you please document in docs/actions.md this feature? Thank you! I believe this PR is good to merge then.
|
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Can we please merge it? |
|
there is still one comment to be addressed and the last commit would deserve a better name :P |
|
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Remove an outdated notice Signed-off-by: Hunor Csomortáni [email protected] Reviewed-by: Jiri Popelka <None> Reviewed-by: None <None>
Fixes #268