Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

[#177017837] Added new api for retrieving eyca card #25

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Add getEycaStatus API
  • Add tests

Motivation and Context

While a citizen requests for a CGN and he's between 18 up to 30 years old, he wants also activate an EYCA card ( CGN and EYCA are co-badged ). We need to provide an API that could return detailed information about an EYCA Card.

How Has This Been Tested?

It has been tested by performing unit tests .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Feb 19, 2021

Warnings
⚠️ This PR changes a total of 298 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.

Affected stories

  • 🌟 #177017837: Come APP, voglio richiamare un' API che mi consenta di conoscere i dettagli sullo stato di una Carta EYCA, in modo da poter mostrare le informazioni sul wallet

Generated by 🚫 dangerJS against 63360ab

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #25 (63360ab) into master (d2e0560) will decrease coverage by 0.04%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   81.01%   80.97%   -0.05%     
==========================================
  Files          32       33       +1     
  Lines         864      883      +19     
  Branches       99       99              
==========================================
+ Hits          700      715      +15     
- Misses        159      163       +4     
  Partials        5        5              
Impacted Files Coverage Δ
GetEycaStatus/handler.ts 80.00% <80.00%> (ø)
GetCgnStatus/handler.ts 80.00% <100.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1263e...63360ab. Read the comment docs.

Copy link
Contributor

@AleDore AleDore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit 70778e0 into master Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants