This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
[#177116930] Add EYCA expiration process #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 82.89% 84.55% +1.65%
==========================================
Files 36 43 +7
Lines 1076 1347 +271
Branches 121 145 +24
==========================================
+ Hits 892 1139 +247
- Misses 179 203 +24
Partials 5 5
Continue to review full report at Codecov.
|
BurnedMarshal
suggested changes
Mar 29, 2021
UpdateExpiredEyca/handler.ts
Outdated
Comment on lines
97
to
107
| // tslint:disable-next-line: readonly-array | ||
| const taskArray = []; | ||
| const tasksChunks = chunksOf(tasks, 100); | ||
| for (const tasksChunk of tasksChunks) { | ||
| taskArray.push( | ||
| array | ||
| .sequence(taskEither)(tasksChunk) | ||
| .run() | ||
| ); | ||
| } | ||
| return Promise.all([...taskArray]); |
There was a problem hiding this comment.
Prefer immutable array when possible
Suggested change
| // tslint:disable-next-line: readonly-array | |
| const taskArray = []; | |
| const tasksChunks = chunksOf(tasks, 100); | |
| for (const tasksChunk of tasksChunks) { | |
| taskArray.push( | |
| array | |
| .sequence(taskEither)(tasksChunk) | |
| .run() | |
| ); | |
| } | |
| return Promise.all([...taskArray]); | |
| return Promise.all( | |
| chunksOf(tasks, 100).map(_ => | |
| array | |
| .sequence(taskEither)(_) | |
| .run() | |
| ) | |
| ); |
| // Now we try to start Expire operation | ||
| return tryCatch( | ||
| () => | ||
| client.startNew( |
There was a problem hiding this comment.
What if the orchestration start fail? We have no retry here and the card remains unapdated.
There was a problem hiding this comment.
Yes, this is a good point. I guess that in this case we must raise an alert with trackException below and proceed to change the state with a script. Another possibility is to create a queue that can retry the expiration process. What do you think about?
BurnedMarshal
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
UpdateExpiredEycatriggerExpireEycaOrchestratorExpireEycaActivityMotivation and Context
n EYCA card must expires after a citizen has reached 31 years old, so it' necessary to schedule a trigger that could do this job, intended for:
EXPIREDPlease refer to related story for further informations.
How Has This Been Tested?
It has been tested by performing unit tests.
Types of changes
Checklist: