This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
[#176466130] Add Update CGN status activity #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunzip
suggested changes
Jan 13, 2021
UpdateCgnStatusActivity/handler.ts
Outdated
| description === "" | ||
| ? `${logPrefix}|FAILURE=${err.message}` | ||
| : `${logPrefix}|${description}|FAILURE=${err.message}`; | ||
| context.log.verbose(logMessage); |
There was a problem hiding this comment.
Suggested change
| context.log.verbose(logMessage); | |
| context.log.info(logMessage); |
UpdateCgnStatusActivity/handler.ts
Outdated
| ) | ||
| .chain(_ => | ||
| userCgnModel.update(_).bimap( | ||
| () => fail(new Error("Cannot update userCgn")), |
There was a problem hiding this comment.
I'd keep the error message from update() method (it could be 409 conflict)
UpdateCgnStatusActivity/index.ts
Outdated
Comment on lines
2
to
10
| * This function is not intended to be invoked directly. Instead it will be | ||
| * triggered by an orchestrator function. | ||
| * | ||
| * Before running this sample, please: | ||
| * - create a Durable orchestration function | ||
| * - create a Durable HTTP starter function | ||
| * - run 'yarn add durable-functions' from the wwwroot folder of your | ||
| * function app in Kudu | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * This function is not intended to be invoked directly. Instead it will be | |
| * triggered by an orchestrator function. | |
| * | |
| * Before running this sample, please: | |
| * - create a Durable orchestration function | |
| * - create a Durable HTTP starter function | |
| * - run 'yarn add durable-functions' from the wwwroot folder of your | |
| * function app in Kudu | |
| */ |
gunzip
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
UpdateCgnStatusActivityconversionsutilityMotivation and Context
CGN' status change operations must be addressed by a specific activity that can do the job, even if it is triggered by an orchestrator with proper retry logic.
How Has This Been Tested?
It has been tested by performing unit tests.
Types of changes
Checklist: