[#176013578] Use custom command to publish package #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
requested review from
AleDore,
BurnedMarshal,
francescopersico and
gunzip
as code owners
balanza
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 33 33
Lines 880 880
Branches 86 90 +4
=======================================
Hits 743 743
Misses 134 134
Partials 3 3
Continue to review full report at Codecov.
|
gunzip
reviewed
Jan 4, 2021
| @@ -124,7 +124,8 @@ stages: | |||
|
|
|||
| - task: Npm@1 | |||
| inputs: | |||
| command: publish | |||
| command: custom | |||
| customCommand: publish --access public | |||
balanza
pushed a commit
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work of #129, I'm trying to get the package published.
In this PR I try to do it with a custom command instead of the built-in
publishoption. This is needed in order to instruct on the access level required by the package (public).Since
io-functions-commonsis a scoped package, as by npm docs the default access value isrestricted.I also opened an issue on the Azure task repo.