Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable republish_images to have a source tag filter #537

Closed
3 tasks
dmikusa opened this issue Feb 4, 2022 · 2 comments
Closed
3 tasks

Enable republish_images to have a source tag filter #537

dmikusa opened this issue Feb 4, 2022 · 2 comments
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Feb 4, 2022

What happened?

At the present moment, the republish_images job will assume that one source repository is used for one buildpack. If you have multiple buildpacks under a source repo then you will be tagging releases with some tag prefix, like buildpack-a-v1.0 and buildpack-b-v1.0.

This request is so that the job applies a filter like buildpack-a-* to fetch the right tag set (using git tag -l might be an option in the scripts). It will also need to parse out the version, as we need the version in the scripts. This might require a regex with a capture group, but other options are acceptable too.

Build Configuration

  • What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
    using? Please include a version.

  • What buildpacks are you using? Please include versions.

  • What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?

  • Can you provide a sample app or relevant configuration (buildpack.yml,
    nginx.conf, etc.)?

Checklist

  • I have included log output.
  • The log output includes an error message.
  • I have included steps for reproduction.
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Feb 4, 2022
@dmikusa
Copy link
Contributor Author

dmikusa commented Feb 9, 2022

Closed by #543

@dmikusa dmikusa closed this as completed Feb 9, 2022
@andrew-su
Copy link
Contributor

Looks like https://github.com/paketo-buildpacks/pipeline-builder/blob/main/octo/compute-version.sh used by builder and package may need to be updated to handle tags differently too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants