Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rsvg to generate pngs from vector files #50

Closed
willgearty opened this issue Apr 20, 2023 · 0 comments · Fixed by #52
Closed

Use rsvg to generate pngs from vector files #50

willgearty opened this issue Apr 20, 2023 · 0 comments · Fixed by #52
Assignees
Milestone

Comments

@willgearty
Copy link
Collaborator

willgearty commented Apr 20, 2023

Sometimes there isn't a png of the desired size available on phylopic (e.g., #46). We now catch this and throw and warning and fall back to the largest available png (#47), but sometimes only a very small png is available, which might not be desirable. Now, as we've discussed, we don't really want to encourage the use of pngs, but it should be fairly straightforward to just generate the pngs ourself from phylopic's vector.svg image using rsvg_png and readPNG. This way users could theoretically specify any desired png size and we would be able to make it for them (although perhaps we could still download the existing png if it exists for the desired size to be faster).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants