Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Icon> with Intent on a component with dark background (eg. Tooltip2) has too dark colors #5072

Closed
Blizzara opened this issue Dec 14, 2021 · 0 comments · Fixed by #5287
Closed

Comments

@Blizzara
Copy link

Blizzara commented Dec 14, 2021

Icon's Intent colors don't fulfill accessibility standards when used on a Tooltip2, which has a dark background:
image

Would likely need something similar than Icon-on-dark-mode styles:

color: map-get($pt-dark-intent-text-colors, $intent);

Might be worth checking other Intent-taking objects as well as other dark backgrounds for the same problem (if there are any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants