react-transition-group becomes regular dependency of core #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it is no longer a react dependency, and has its own peer deps on react. caveat: r-t-g's peer dep is react ^15.0.0, so ^0.14 is no longer valid to install... remove dev deps from packages that don't use r-t-g
react-transition-group becomes regular dependency of corePreview: documentation | landing | table |
cmslewis
approved these changes
May 12, 2017
|
@giladgray lemme handle it for the sake of teaching myself more about the release process. @adidahiya if you wanna lend a hand, I'd appreciate it. |
|
Our options look like this (correct me if I'm wrong):
I'd actually advocate for (3); we can release 2.0.0-rc.0 with the React 16 compatible changes when it's appropriate (maybe when we think 16 is imminent). Thoughts? |
|
Oops - apologies, I should've really picked up on this! Thanks for taking care of the fire :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken 1.17.0 release
@zerovox points out that changing a peer dependency like we did in #1063 is basically a breaking change as it requires action from every user.
fortunately, un-breaking the API is pretty easy: we can take
react-transition-groupon as a regular dependency, rather than a peer dependency. this is legit because it is no longer a react-addon package and does not make awkward use of theReactglobal variable. it also has its own peer dependencies on react.react-transition-grouppeer dependency on react is^15.0.0so it is no longer valid to install[email protected]alongside Blueprint (even though we technically support it). @adidahiya how acceptable is this?I also removed
r-t-gdev dependencies from packages that don't use it (which is most of them--it's only used once inOverlay).Reviewers should focus on
@adidahiya @cmslewis we should ship a patch release 1.17.1 after this merges to unbreak future installers. i'll be on a plane from 8:30am PST, if one of you could please handle that?