Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #1247

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Sep 17, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.6.0

Type Description Link
Fix Excavator PRs that apply other refaster rules (e.g. Witchcraft ones) will not also apply baseline refaster rules. palantir/gradle-baseline#827
Improvement Added a new ErrorProne check PreferAssertj to assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency on org.assertj:assertj-core in modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used, PreferAssertj may be explicitly disabled to prevent future upgrades from attempting to re-run the migration. palantir/gradle-baseline#841

2.7.0

Type Description Link
Improvement StrictUnusedVariable now ignores variables prefixed with _ and the suggested fix will rename all unused parameters in public methods instead of removing them palantir/gradle-baseline#833
Improvement ErrorProne will now detect dangerous usage of @RunWith(Suite.class) that references JUnit5 classes, as this can cause tests to silently not run! palantir/gradle-baseline#843

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 735fc30 to 5c327b5 Compare September 18, 2019 16:11
@ferozco ferozco force-pushed the roomba/latest-baseline-oss branch from 5c327b5 to 95cae21 Compare September 18, 2019 16:51
@ferozco
Copy link
Contributor

ferozco commented Sep 18, 2019

👍

@bulldozer-bot bulldozer-bot bot merged commit 063f151 into develop Sep 18, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch September 18, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants