diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml index 792229cfc..cd19cae45 100644 --- a/.baseline/checkstyle/checkstyle.xml +++ b/.baseline/checkstyle/checkstyle.xml @@ -53,6 +53,9 @@ + + + @@ -84,11 +87,13 @@ + org.apache.commons.lang3.Validate.*, + org.assertj.core.api.Assertions.*, + org.mockito.Mockito.*"/> @@ -110,7 +115,6 @@ - @@ -369,10 +373,6 @@ - - - - @@ -422,6 +422,7 @@ + @@ -435,7 +436,7 @@ - + @@ -468,10 +469,9 @@ - + - diff --git a/build.gradle b/build.gradle index 336d649b1..ebe5e8a15 100644 --- a/build.gradle +++ b/build.gradle @@ -28,7 +28,7 @@ buildscript { classpath 'com.netflix.nebula:gradle-info-plugin:5.2.0' classpath 'com.netflix.nebula:nebula-publishing-plugin:14.1.1' classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' - classpath 'com.palantir.baseline:gradle-baseline-java:0.65.0' + classpath 'com.palantir.baseline:gradle-baseline-java:2.35.2' classpath 'com.palantir.gradle.conjure:gradle-conjure:4.13.4' classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.2' classpath 'gradle.plugin.org.inferred:gradle-processors:3.1.0' diff --git a/conjure-python-core/src/main/java/com/palantir/conjure/python/PythonAliasTopologicalSorter.java b/conjure-python-core/src/main/java/com/palantir/conjure/python/PythonAliasTopologicalSorter.java index 4a0514c6c..6e6a16089 100644 --- a/conjure-python-core/src/main/java/com/palantir/conjure/python/PythonAliasTopologicalSorter.java +++ b/conjure-python-core/src/main/java/com/palantir/conjure/python/PythonAliasTopologicalSorter.java @@ -90,7 +90,7 @@ static class AliasEdgeVisitor implements Type.Visitor> { } @Override - public List visitPrimitive(PrimitiveType value) { + public List visitPrimitive(PrimitiveType _value) { return Collections.emptyList(); } @@ -126,7 +126,7 @@ public List visitReference(TypeName value) { } @Override - public List visitExternal(ExternalReference value) { + public List visitExternal(ExternalReference _value) { return Collections.emptyList(); } diff --git a/conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java b/conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java index 509dbb9a2..d5b3f54f4 100644 --- a/conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java +++ b/conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java @@ -223,7 +223,7 @@ static Builder builder() { } @Value.Immutable - public interface PythonEndpointParam { + interface PythonEndpointParam { String paramName(); diff --git a/conjure-python-core/src/test/java/com/palantir/conjure/python/ConjureSubfolderRunner.java b/conjure-python-core/src/test/java/com/palantir/conjure/python/ConjureSubfolderRunner.java index 0f5eb7a03..bd7bbd219 100644 --- a/conjure-python-core/src/test/java/com/palantir/conjure/python/ConjureSubfolderRunner.java +++ b/conjure-python-core/src/test/java/com/palantir/conjure/python/ConjureSubfolderRunner.java @@ -149,7 +149,7 @@ private Optional maybeParallelScheduler(ParentFolder annotation @Override @SuppressWarnings("FutureReturnValueIgnored") public void schedule(Runnable childStatement) { - executor.submit(childStatement); + executor.execute(childStatement); } @Override diff --git a/conjure-python/src/main/java/com/palantir/conjure/python/cli/ConjurePythonCli.java b/conjure-python/src/main/java/com/palantir/conjure/python/cli/ConjurePythonCli.java index e77325f7f..55ac5de4a 100644 --- a/conjure-python/src/main/java/com/palantir/conjure/python/cli/ConjurePythonCli.java +++ b/conjure-python/src/main/java/com/palantir/conjure/python/cli/ConjurePythonCli.java @@ -29,7 +29,6 @@ import java.io.File; import java.io.IOException; import java.nio.file.Paths; -import java.util.List; import java.util.Optional; import picocli.CommandLine; @@ -89,9 +88,7 @@ public static final class GenerateCommand implements Runnable { description = "Generate a `conda_recipe/meta.yaml`") private boolean writeCondaRecipe; - @CommandLine.Unmatched - @SuppressWarnings("UnusedVariable") - private List unmatchedOptions; + @Override public void run() {