Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change {Async,}RequestBody::Streaming to store a boxed writer #259

Closed
sfackler opened this issue Jul 7, 2023 · 0 comments · Fixed by #268
Closed

Change {Async,}RequestBody::Streaming to store a boxed writer #259

sfackler opened this issue Jul 7, 2023 · 0 comments · Fixed by #268

Comments

@sfackler
Copy link
Member

sfackler commented Jul 7, 2023

Requiring a borrowed request writer can be a bit limiting for {Async,}SerializeRequest implementations. It may be better to just pay the allocation cost and pass an owned writer in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stacked] Box streaming request bodies palantir/conjure-rust
1 participant
@sfackler