Promote safe logging checks from SUGGESTION -> WARNING (#704)

* Change safe logging checks severity to WARNING * Changelog
palantir · Jul 22, 2019 · e741062 · e741062
1 parent bab9acc
commit e741062
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/...or-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java b/...or-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java
@@ -39,7 +39,7 @@
         name = "PreferSafeLoggableExceptions",
         link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
         linkType = BugPattern.LinkType.CUSTOM,
-        severity = BugPattern.SeverityLevel.SUGGESTION,
+        severity = BugPattern.SeverityLevel.WARNING,
         summary = "Throw SafeLoggable exceptions to ensure the exception message will not be redacted")
 public final class PreferSafeLoggableExceptions extends BugChecker implements BugChecker.NewClassTreeMatcher {
 

diff --git a/...-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java b/...-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java
@@ -40,7 +40,7 @@
         name = "PreferSafeLoggingPreconditions",
         link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
         linkType = BugPattern.LinkType.CUSTOM,
-        severity = BugPattern.SeverityLevel.SUGGESTION,
+        severity = BugPattern.SeverityLevel.WARNING,
         summary = "Precondition and similar checks with a constant message and no parameters should use equivalent "
                 + "checks from com.palantir.logsafe.Preconditions for standardization as functionality is the same.")
 public final class PreferSafeLoggingPreconditions extends BugChecker implements BugChecker.MethodInvocationTreeMatcher {

diff --git a/changelog/@unreleased/pr-697.v2.yml b/changelog/@unreleased/pr-697.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: The severity of PreferSafeLoggableExceptions and PreferSafeLoggingPreconditions is now WARNING.
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/704