Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove safe-logging preconditions constant string check #511

Closed
carterkozak opened this issue Jan 17, 2019 · 1 comment
Closed

Remove safe-logging preconditions constant string check #511

carterkozak opened this issue Jan 17, 2019 · 1 comment
Assignees
@carterkozak
Labels
error-prone

Comments

@carterkozak
Copy link
Contributor

Once safe-logging with this change has been adopted we no longer need to support the validator specific to safe-logging preconditions: palantir/safe-logging#104
@carterkozak
Copy link
Contributor Author

We should likely wait a month or so before making this change.

@carterkozak carterkozak self-assigned this Jan 19, 2019
carterkozak added a commit that referenced this issue Aug 16, 2019
@carterkozak
fix #511: remove errorprone LogSafePreconditionsConstantMessage
1cf7873 
This check is unnecessary with safe-logging 1.8.0 and beyond, which
use `@CompileTimeConstant` annotations on Preconditions message
arguments.
palantir/safe-logging#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carterkozak carterkozak

Labels
error-prone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carterkozak