From ceb62a44258f86feb2bdc78aa42325a9c9627558 Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Wed, 6 Nov 2019 12:44:53 -0500 Subject: [PATCH 1/2] Drop RedundantModifier to SUGGESTION and FinalClass to WARNING --- .../main/java/com/palantir/baseline/errorprone/FinalClass.java | 2 +- .../com/palantir/baseline/errorprone/RedundantModifier.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/FinalClass.java b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/FinalClass.java index 4258f3a33..df65a108f 100644 --- a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/FinalClass.java +++ b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/FinalClass.java @@ -44,7 +44,7 @@ link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", linkType = BugPattern.LinkType.CUSTOM, providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION, - severity = BugPattern.SeverityLevel.ERROR, + severity = BugPattern.SeverityLevel.WARNING, summary = "A class should be declared final if all of its constructors are private. Utility classes -- " + "i.e., classes all of whose methods and fields are static -- have a private, empty, " + "zero-argument constructor.\n" diff --git a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RedundantModifier.java b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RedundantModifier.java index 9030f85a3..ce8dc410b 100644 --- a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RedundantModifier.java +++ b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RedundantModifier.java @@ -42,7 +42,7 @@ link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", linkType = BugPattern.LinkType.CUSTOM, providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION, - severity = BugPattern.SeverityLevel.ERROR, + severity = BugPattern.SeverityLevel.SUGGESTION, summary = "Avoid using redundant modifiers") public final class RedundantModifier extends BugChecker implements BugChecker.ClassTreeMatcher, BugChecker.MethodTreeMatcher, BugChecker.VariableTreeMatcher { From 7d6031f95c7810a98137fd21c64c750e8774080c Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Wed, 6 Nov 2019 17:44:53 +0000 Subject: [PATCH 2/2] Add generated changelog entries --- changelog/@unreleased/pr-1028.v2.yml | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 changelog/@unreleased/pr-1028.v2.yml diff --git a/changelog/@unreleased/pr-1028.v2.yml b/changelog/@unreleased/pr-1028.v2.yml new file mode 100644 index 000000000..398879a9b --- /dev/null +++ b/changelog/@unreleased/pr-1028.v2.yml @@ -0,0 +1,9 @@ +type: improvement +improvement: + description: |- + Drop RedundantModifier to SUGGESTION and FinalClass to WARNING + + These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation. + FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time. + links: + - https://github.com/palantir/gradle-baseline/pull/1028