Some low-effort AssertJ refasters

.baseline/checkstyle/custom-suppressions.xml

@@ -8,4 +8,7 @@
 <suppressions>
     <!-- Do not lint class which is mostly copied -->
     <suppress files=".*StrictUnusedVariable.java" checks="." />
+
+    <!-- We have a special whitelist for AssertJ's assertThat method in test code, but we need it in prod code -->
+    <suppress files="src/main/java/com/palantir/baseline/refaster" checks="AvoidStaticImport" />
 </suppressions>

baseline-refaster-rules/build.gradle

@@ -4,7 +4,8 @@ apply plugin: 'java-library'
 apply from: "${rootDir}/gradle/publish-jar.gradle"
 
 dependencies {
-    compile 'com.google.errorprone:error_prone_refaster'
+    implementation 'com.google.errorprone:error_prone_refaster'
+    implementation 'org.assertj:assertj-core'
 
     testCompile 'junit:junit'
     testCompile project(':baseline-refaster-testing')

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjCollectionHasSizeExactly.java

@@ -0,0 +1,41 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.Collection;
+
+public final class AssertjCollectionHasSizeExactly<T> {
+
+    @BeforeTemplate
+    void bad1(Collection<T> things, int size) {
+        assertThat(things.size() == size).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad2(Collection<T> things, int size) {
+        assertThat(things.size()).isEqualTo(size);
+    }
+
+    @AfterTemplate
+    void after(Collection<T> things, int size) {
+        assertThat(things).hasSize(size);
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjCollectionHasSizeGreaterThan.java

@@ -0,0 +1,36 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.Collection;
+
+public final class AssertjCollectionHasSizeGreaterThan<T> {
+
+    @BeforeTemplate
+    void before(Collection<T> things, int size) {
+        assertThat(things.size() > size).isTrue();
+    }
+
+    @AfterTemplate
+    void after(Collection<T> things, int size) {
+        assertThat(things).hasSizeGreaterThan(size);
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjCollectionIsEmpty.java

@@ -0,0 +1,74 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.Collection;
+import java.util.Collections;
+
+public final class AssertjCollectionIsEmpty<T> {
+
+    @BeforeTemplate
+    void bad1(Collection<T> things) {
+        assertThat(things.size() == 0).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad2(Collection<T> things) {
+        assertThat(things.isEmpty()).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad3(Collection<T> things) {
+        assertThat(things.size() == 0).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad4(Collection<T> things) {
+        assertThat(things).isEqualTo(Collections.emptyList());
+    }
+
+    @BeforeTemplate
+    void bad5(Collection<T> things) {
+        assertThat(things).isEqualTo(Collections.emptySet());
+    }
+
+    @BeforeTemplate
+    void bad6(Collection<T> things) {
+        assertThat(things).isEqualTo(ImmutableList.of());
+    }
+
+    @BeforeTemplate
+    void bad7(Collection<T> things) {
+        assertThat(things).isEqualTo(ImmutableSet.of());
+    }
+
+    @BeforeTemplate
+    void bad8(Collection<T> things) {
+        assertThat(things).hasSize(0);
+    }
+
+    @AfterTemplate
+    void after(Collection<T> things) {
+        assertThat(things).isEmpty();
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjCollectionIsNotEmpty.java

@@ -0,0 +1,79 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.Collection;
+import java.util.Collections;
+
+public final class AssertjCollectionIsNotEmpty<T> {
+
+    @BeforeTemplate
+    void bad1(Collection<T> things) {
+        assertThat(things.size() != 0).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad2(Collection<T> things) {
+        assertThat(things.size() == 0).isFalse();
+    }
+
+    @BeforeTemplate
+    void bad3(Collection<T> things) {
+        assertThat(things.size()).isNotEqualTo(0);
+    }
+
+    @BeforeTemplate
+    void bad4(Collection<T> things) {
+        assertThat(things.isEmpty()).isFalse();
+    }
+
+    @BeforeTemplate
+    void bad5(Collection<T> things) {
+        assertThat(!things.isEmpty()).isTrue();
+    }
+
+    @BeforeTemplate
+    void bad6(Collection<T> things) {
+        assertThat(things).isNotEqualTo(Collections.emptyList());
+    }
+
+    @BeforeTemplate
+    void bad7(Collection<T> things) {
+        assertThat(things).isNotEqualTo(Collections.emptySet());
+    }
+
+    @BeforeTemplate
+    void bad8(Collection<T> things) {
+        assertThat(things).isNotEqualTo(ImmutableList.of());
+    }
+
+    @BeforeTemplate
+    void bad9(Collection<T> things) {
+        assertThat(things).isNotEqualTo(ImmutableSet.of());
+    }
+
+    @AfterTemplate
+    void after(Collection<T> things) {
+        assertThat(things).isNotEmpty();
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjFileContent.java

@@ -0,0 +1,45 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.common.io.Files;
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+
+public final class AssertjFileContent<T> {
+
+    @BeforeTemplate
+    void before(File file, String expected) throws IOException {
+        assertThat(new String(Files.toByteArray(file), StandardCharsets.UTF_8)).isEqualTo(expected);
+    }
+
+    @BeforeTemplate
+    @SuppressWarnings("deprecation") // we're migrating people off a deprecated method
+    void before2(File file, String expected) throws IOException {
+        assertThat(Files.toString(file, StandardCharsets.UTF_8)).isEqualTo(expected);
+    }
+
+    @AfterTemplate
+    void after(File file, String expected) {
+        assertThat(file).hasContent(expected);
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjOptionalIsPresent.java

@@ -0,0 +1,36 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import java.util.Optional;
+
+public final class AssertjOptionalIsPresent<T> {
+
+    @BeforeTemplate
+    void before(Optional<T> thing) {
+        assertThat(thing.isPresent()).isTrue();
+    }
+
+    @AfterTemplate
+    void after(Optional<T> thing) {
+        assertThat(thing).isPresent();
+    }
+}

changelog/@unreleased/pr-851.v2.yml

@@ -0,0 +1,6 @@
+type: improvement
+improvement:
+  description: Some AssertJ assertions can now be automatically replaced with more
+    idiomatic ones using refaster.
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/851