diff --git a/changelog/@unreleased/pr-885.v2.yml b/changelog/@unreleased/pr-885.v2.yml new file mode 100644 index 000000000..1bf769c99 --- /dev/null +++ b/changelog/@unreleased/pr-885.v2.yml @@ -0,0 +1,5 @@ +type: fix +fix: + description: checkJunitDependencies only checks Java source + links: + - https://github.com/palantir/gradle-baseline/pull/885 diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java index 5a47210b7..246444e4c 100644 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java +++ b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java @@ -134,7 +134,7 @@ private boolean hasDep(String configurationName, Predicate fileContainsSubstring(file, l -> l.contains("org.junit.Test") || l.contains("org.junit.runner") @@ -143,7 +143,7 @@ private boolean sourceSetMentionsJUnit4(SourceSet ss) { } private boolean sourceSetMentionsJUnit5Api(SourceSet ss) { - return !ss.getAllSource() + return !ss.getAllJava() .filter(file -> fileContainsSubstring(file, l -> l.contains("org.junit.jupiter.api."))) .isEmpty(); }