Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the lock file with consistent line endings (or make them configurable) #829

Open
dweiss opened this issue Dec 13, 2021 · 0 comments
Open

Comments

@dweiss
Copy link

dweiss commented Dec 13, 2021

Currently ConflictSafeLockFile.java uses writer.newLine which emits system-dependent line endings. This is mildly annoying as it results in file differences on different systems.

I think it'd be great to either allow the line endings to be configurable... or at least write to an in-memory buffer, compare against the existing file and not touch it if the content is whitespace-identical.

I can provide a patch for this, if you're interested, but it should be a trivial change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant