Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

revapi plugin doesn't detect change after upgrading to gradle 8.2.0/8.3.0 #612

Open
jbonofre opened this issue Oct 4, 2023 · 1 comment

Comments

@jbonofre
Copy link

jbonofre commented Oct 4, 2023

What happened?

I'm using revapi gradle plugin 1.7.0. With Gradle 8.1.1, all works fine. If I change an API, revapi detects it and my build fails with API/ABI breaks detected.. All good.

However, since Gradle 8.2.0 (and it's still the case with Gradle 8.3.0), API changes are not detected instead of failing when an API breaks is detected.

As it's with the same revapi gradle plugin version (1.7.0), I suspect a change in Gradle 8.2 (maybe needing a change in revapi plugin). I gonna do a git bisect to find what changed in Gradle 8.2 (compared to Gradle 8.1).

What did you want to happen?

revapi plugin should work with Gradle 8.2+.

@jbonofre jbonofre changed the title revapi plugin doesn't detect change after upgrading to gradle 8.3.0 revapi plugin doesn't detect change after upgrading to gradle 8.2.0/8.3.0 Oct 4, 2023
@jbonofre
Copy link
Author

I found the main cause of this issue. The revapi plugin uses the same artifact for both old and new API, so that's why no change is detected.
Even by setting revapi oldVersion configuration, it still uses the default project artifact.
It's related to the way gradle 8.2+ is populating the property on task. I'm checking if I can find a workaround on gradle directly, else I will create a PR to fix that by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant