diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml
index 2be3288d7..6803583ad 100644
--- a/.baseline/checkstyle/checkstyle.xml
+++ b/.baseline/checkstyle/checkstyle.xml
@@ -69,7 +69,9 @@
-
+
+
+
@@ -81,14 +83,7 @@
-
+
@@ -138,12 +133,12 @@
-
+
-
+
@@ -358,7 +353,7 @@
-
+
@@ -397,7 +392,7 @@
-
+
@@ -430,7 +425,7 @@
-
+
diff --git a/.baseline/idea/intellij-java-palantir-style.xml b/.baseline/idea/intellij-java-palantir-style.xml
index 945d8bad0..f41e2b8aa 100644
--- a/.baseline/idea/intellij-java-palantir-style.xml
+++ b/.baseline/idea/intellij-java-palantir-style.xml
@@ -44,6 +44,18 @@
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/build.gradle b/build.gradle
index d91720bf2..4cdc4f738 100644
--- a/build.gradle
+++ b/build.gradle
@@ -7,7 +7,7 @@ buildscript {
dependencies {
classpath 'com.palantir.gradle.externalpublish:gradle-external-publish-plugin:1.4.0'
classpath 'com.github.jengelman.gradle.plugins:shadow:6.1.0'
- classpath 'com.palantir.baseline:gradle-baseline-java:3.43.0'
+ classpath 'com.palantir.baseline:gradle-baseline-java:4.25.0'
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.0.0'
}
}
diff --git a/crypto-core/src/main/java/com/palantir/crypto2/io/ApacheCtrDecryptingSeekableInput.java b/crypto-core/src/main/java/com/palantir/crypto2/io/ApacheCtrDecryptingSeekableInput.java
index 7d5c6074b..1a07537ec 100644
--- a/crypto-core/src/main/java/com/palantir/crypto2/io/ApacheCtrDecryptingSeekableInput.java
+++ b/crypto-core/src/main/java/com/palantir/crypto2/io/ApacheCtrDecryptingSeekableInput.java
@@ -58,8 +58,8 @@ public long getPos() throws IOException {
}
@Override
- public int read(byte[] bytes, int offset, int length) throws IOException {
- return super.read(bytes, offset, length);
+ public int read(byte[] bytes, int off, int len) throws IOException {
+ return super.read(bytes, off, len);
}
@Override
diff --git a/crypto-keys/src/main/java/com/palantir/crypto2/keys/ChainedKeyStorageStrategy.java b/crypto-keys/src/main/java/com/palantir/crypto2/keys/ChainedKeyStorageStrategy.java
index 5a78dd115..70a794743 100644
--- a/crypto-keys/src/main/java/com/palantir/crypto2/keys/ChainedKeyStorageStrategy.java
+++ b/crypto-keys/src/main/java/com/palantir/crypto2/keys/ChainedKeyStorageStrategy.java
@@ -32,7 +32,7 @@
*/
public final class ChainedKeyStorageStrategy implements KeyStorageStrategy {
- private static final Logger logger = LoggerFactory.getLogger(ChainedKeyStorageStrategy.class);
+ private static final Logger log = LoggerFactory.getLogger(ChainedKeyStorageStrategy.class);
private final List strategies;
@@ -60,7 +60,10 @@ public KeyMaterial get(String fileKey) {
return strategy.get(fileKey);
} catch (Exception e) {
suppressedExceptions.add(e);
- logger.info("Failed to get key material using {}", strategy.getClass().getCanonicalName(), e);
+ log.info(
+ "Failed to get key material using {}",
+ strategy.getClass().getCanonicalName(),
+ e);
}
}
RuntimeException toThrow = new RuntimeException(String.format(
diff --git a/crypto-keys/src/main/java/com/palantir/crypto2/keys/KeyMaterial.java b/crypto-keys/src/main/java/com/palantir/crypto2/keys/KeyMaterial.java
index e277619d5..64c0e8d75 100644
--- a/crypto-keys/src/main/java/com/palantir/crypto2/keys/KeyMaterial.java
+++ b/crypto-keys/src/main/java/com/palantir/crypto2/keys/KeyMaterial.java
@@ -20,6 +20,8 @@
import org.immutables.value.Value;
// This class is not Jackson serializable due to SecretKey
+// Automatically suppressed to unblock enforcement in new code
+@SuppressWarnings("ImmutablesStyle")
@Value.Immutable
@Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE, jdkOnly = true)
public abstract class KeyMaterial {
diff --git a/hadoop-crypto/src/main/java/com/palantir/crypto2/hadoop/DelegatingFileSystem.java b/hadoop-crypto/src/main/java/com/palantir/crypto2/hadoop/DelegatingFileSystem.java
index fbebd2237..c0b6da48d 100644
--- a/hadoop-crypto/src/main/java/com/palantir/crypto2/hadoop/DelegatingFileSystem.java
+++ b/hadoop-crypto/src/main/java/com/palantir/crypto2/hadoop/DelegatingFileSystem.java
@@ -34,7 +34,7 @@
*/
public abstract class DelegatingFileSystem extends FilterFileSystem {
- public DelegatingFileSystem(FileSystem delegate) {
+ protected DelegatingFileSystem(FileSystem delegate) {
super(delegate);
try {
super.initialize(delegate.getUri(), delegate.getConf());