Apply the error-prone CompileTimeConstant annotation to safe messages #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Do we also want to annotate the key argument of SafeArg.of and UnsafeArg.of? |
|
Seems like a good idea |
|
Ah, the safe-logging module doesn't depend on error-prone. I'll make a separate PR for that. |
This was referenced Jan 17, 2019
carterkozak
added a commit
to palantir/gradle-baseline
that referenced
this pull request
Aug 16, 2019
This check is unnecessary with safe-logging 1.8.0 and beyond, which use `@CompileTimeConstant` annotations on Preconditions message arguments. palantir/safe-logging#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the default CompileTimeConstant errorprone check to catch unsafe uses of safe-logging preconditions and exceptions.