[SPARK-27134][SQL] array_distinct function does not work correctly with columns containing array of array #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th columns containing array of array
## What changes were proposed in this pull request?
Correct the logic to compute the distinct.
Below is a small repro snippet.
```
scala> val df = Seq(Seq(Seq(1, 2), Seq(1, 2), Seq(1, 2), Seq(3, 4), Seq(4, 5))).toDF("array_col")
df: org.apache.spark.sql.DataFrame = [array_col: array<array<int>>]
scala> val distinctDF = df.select(array_distinct(col("array_col")))
distinctDF: org.apache.spark.sql.DataFrame = [array_distinct(array_col): array<array<int>>]
scala> df.show(false)
+----------------------------------------+
|array_col |
+----------------------------------------+
|[[1, 2], [1, 2], [1, 2], [3, 4], [4, 5]]|
+----------------------------------------+
```
Error
```
scala> distinctDF.show(false)
+-------------------------+
|array_distinct(array_col)|
+-------------------------+
|[[1, 2], [1, 2], [1, 2]] |
+-------------------------+
```
Expected result
```
scala> distinctDF.show(false)
+-------------------------+
|array_distinct(array_col)|
+-------------------------+
|[[1, 2], [3, 4], [4, 5]] |
+-------------------------+
```
## How was this patch tested?
Added an additional test.
Closes apache#24073 from dilipbiswal/SPARK-27134.
Authored-by: Dilip Biswal <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
(cherry picked from commit aea9a57)
Signed-off-by: Sean Owen <[email protected]>
rshkv
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct the logic to compute the distinct.
Below is a small repro snippet.
Error
Expected result
How was this patch tested?
Added an additional test.
Closes apache#24073 from dilipbiswal/SPARK-27134.
Authored-by: Dilip Biswal [email protected]
Signed-off-by: Sean Owen [email protected]
(cherry picked from commit aea9a57)
Signed-off-by: Sean Owen [email protected]
Upstream SPARK-27134 ticket and PR link (if not applicable, explain)
https://issues.apache.org/jira/browse/SPARK-27134
What changes were proposed in this pull request?
Fixing bug with array_distinct
How was this patch tested?
Existing tests
Please review http://spark.apache.org/contributing.html before opening a pull request.