Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule suggestion: no-spaces-in-singleline #188

Closed
vjsingh opened this issue Nov 14, 2018 · 2 comments
Closed

New rule suggestion: no-spaces-in-singleline #188

vjsingh opened this issue Nov 14, 2018 · 2 comments

Comments

@vjsingh
Copy link

vjsingh commented Nov 14, 2018

Currently, the following will cause a generic React Native error on Android, with no line number or file. This makes debugging difficult:

<Tag> {children}</Tag>
(see facebook/react-native#18773)

It would be nice if tslint could catch these extra spaces in single-line JSX for me.

Alternatively, a more brutish approach could be to disallow single line JSX entirely, but that isn't a great solution.

*by single-line JSX I mean lines with the opening and closing tags on the same line

@adidahiya
Copy link
Contributor

Seems to be addressed in ESLint according to that issue thread you linked. Also closing due to #210

@vjsingh
Copy link
Author

vjsingh commented Aug 22, 2019

Fair enough, thanks @adidahiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants