-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript definitions #118
Comments
That would be splendid. I am using TypeScript myself these days for some projects. Do you think the main file should cover both the core and the modules? Or should the modules have separate type definitions? |
If I followed the contrived history of typescript definitions files correctly, then ambient definition files are kind of deprecated right now. That would only leave external modules, i.e a file for each entry point; if they have the same name as the module itself, they should be picked up automatically on import, no need to link the definitions separately. |
@AlexGalays, so — one file per module, correct? |
@StreetStrider yes |
That sounds correct. |
Sorry - how is it possible to get typescript to recognize flyd? I don't see any typescript definitions... |
I've been using flyd in my project and started to put together some definitions for flow. They could likely serve as a starting point for the typescript defs. (I'm not personally familiar with writing definitions for ts). Opened a PR to |
#166 adds typescript definitions for flyd and modules. |
You should close the issues once they are resolved. |
What would be your feeling about including typescript definitions directly inside the repo?
It's just one
d.ts
file that is linked from the package.json.The text was updated successfully, but these errors were encountered: