python3: socket._fileobject removed

[buhman]

testcase:

#!/usr/bin/env python3

from werkzeug.serving import run_simple
from OpenSSL import SSL

def hello(env, res):
    res(b'200 OK', [(b'Content-Type', b'text/html')])
    return [b'hello\n']

context = SSL.Context(SSL.TLSv1_METHOD)
context.use_privatekey_file('key.pem')
context.use_certificate_file('cert.pem')

run_simple('localhost', 5000, hello, 
           use_reloader=True, ssl_context=context)

First, you'll need to (trivially) work around pyopenssl's LP#1211834 (2to3 OpenSSL/tsafe.py).

If you simply 'curl https://localhost:5000':

Exception happened during processing of request from ('127.0.0.1', 57812)
Traceback (most recent call last):
  File "/usr/lib/python3.3/socketserver.py", line 306, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python3.3/socketserver.py", line 332, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python3.3/socketserver.py", line 345, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.3/socketserver.py", line 664, in __init__
    self.setup()
  File "/usr/lib/python3.3/socketserver.py", line 716, in setup
    self.rfile = self.connection.makefile('rb', self.rbufsize)
  File "/usr/lib/python3.3/site-packages/werkzeug/serving.py", line 368, in makefile
    return socket._fileobject(self._con, mode, bufsize)
AttributeError: 'module' object has no attribute '_fileobject'

I'd also noticed OpenSSL.SSL.Connection.makefile() is unimplemented, which is presumably the entire purpose of werkzeug.serving._SSLConnectionFix

[thehesiod]

hit the same thing

[redtoad]

same problem here

[depassp]

Having the same problem.

[datagrid]

+1

[dgelvin]

+1

[homeworkprod]

Yes, please work on fixing this.

Ran through a sequence of issues, fixed them myself (and discovered the – yet unreleased – fixes later on in the respective projects: 0bad0c2, 6e5591c, pyca/pyopenssl@65627a2), but gave up after unsuccessfully attempting to use socket.SocketIO instead of socket._fileobject.

I was using Python 3.4 and PyOpenSSL 0.14.

[thehesiod]

I've given up and succesfully switched to tornado.

[asakharov]

+1
Please, support python 3

[untitaker]

Awesome, now I have this problem too, but have enough experience in order to know that this won't get fixed soon.

[DasIch]

Sorry to hear that, though now that you presumably have some motivation you might be able to figure out a good way to fix it ;)

The socket module in Python 3 has changed substantially which makes fixing this quite difficult. As you shouldn't use this in production anyway I think it might make sense to consider dropping this and recommending to use gunicorn, which afaik supports SSL.

[untitaker]

I'm not sure, I think it's useful. #454 actually presents a solution to this.

[untitaker]

For context, i use this in pimutils/vdirsyncer#106

[untitaker]

This is now fixed in #565 and will most likely be included in 0.10. Please note there are some API changes on advanced SSL usage.

[Ivoz]

👏 @untitaker