Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: OrderedDict -> Dict #30469

Closed
alimcmaster1 opened this issue Dec 25, 2019 · 3 comments · Fixed by #36693
Closed

CLN: OrderedDict -> Dict #30469

alimcmaster1 opened this issue Dec 25, 2019 · 3 comments · Fixed by #36693
Assignees
Labels

Comments

@alimcmaster1
Copy link
Member

alimcmaster1 commented Dec 25, 2019

Continue work done in #29923

As of CPython 3.6 the implementation of dict maintains insertion order.

This became a language feature in python 3.7.

Note in python 3.8 support for reversed(dict) was added - but we don't seem to use that in the use cases i've eliminated. ( OrderedDict support this)

Add code check as per comment here: #29923 (comment)

@alimcmaster1
Copy link
Member Author

take

@jbrockmendel
Copy link
Member

grepping for OrderedDict i see 29 usages outside of tests; most of those are either in doctests or in pandas.compat.numpy.function

@alimcmaster1
Copy link
Member Author

@jbrockmendel think I have a branch somewhere that finishes this up - will push over the weekend.

Ali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants