Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hindcast.add_reference() inplace behavior #130

Closed
ahuang11 opened this issue May 19, 2019 · 1 comment
Closed

hindcast.add_reference() inplace behavior #130

ahuang11 opened this issue May 19, 2019 · 1 comment
Assignees
@bradyrx
Labels
infrastructure

Comments

@ahuang11
Copy link
Member

Doing operations in place without setting it to a variable is inconsistent with xarray (they actually deprecated it completely).
pydata/xarray#1756
hc.add_reference(ref_ds, 'ncep')
@bradyrx
Copy link
Collaborator

bradyrx commented May 20, 2019

Yep I agree completely here. Been meaning to make an issue on this. I don't like inplace operations and agree with the deprecation. Should this be a very small PR to make add_reference and add_control not inplace? Those might be the only two functions and no sense in only having inplace in v1...

@bradyrx bradyrx self-assigned this Jul 4, 2019
@bradyrx bradyrx mentioned this issue Aug 22, 2019
Merged
12 tasks
@bradyrx bradyrx mentioned this issue Sep 29, 2019
Merged
9 tasks
@bradyrx bradyrx closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradyrx bradyrx

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradyrx @ahuang11