Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default page size to 1000 #10

Open
davidnmbond opened this issue Aug 12, 2024 · 1 comment
Open

Increase default page size to 1000 #10

davidnmbond opened this issue Aug 12, 2024 · 1 comment
Assignees

Comments

@davidnmbond
Copy link
Contributor

The LogicMonitor documentation states here that the maximum page size is 1000:

https://www.logicmonitor.com/support/v3-swagger-documentation#:~:text=LogicMonitor%20REST%20API%20v3%20supports%20maximum%20size%20of%201000%20records

For years and years (V1 and V2), the maximum page size varied HUGELY between endpoints.  For some, the max size was 25, for most 300.  We had to put a lot of code in the library to adjust these based on the endpoint being called.

However, we value query performance!  So please look at raising this to 1000 across the board, validating EVERY LogicMonitor endpoint before publishing.  There is a LOT of production-critical code relying on successful paging, so it will take a while to validate the change before we can publish it.

@davidnmbond
Copy link
Contributor Author

@davidnmbond davidnmbond changed the title Increase default page sizes to 1000 Increase default page size to 1000 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants