Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Adding a description to analytics #29

Open
JoeyMckenzie opened this issue Nov 2, 2024 · 4 comments
Open

Discussion: Adding a description to analytics #29

JoeyMckenzie opened this issue Nov 2, 2024 · 4 comments

Comments

@JoeyMckenzie
Copy link

Hi!

First and foremost, I'm loving this package. I've been using it on some Statamic websites I run, and having the analytics is super helpful. I was wondering if there's any possibility we might get the ability to add descriptions to targeted elements for analytics sometime in the future.

I'm thinking of a scenario where I could schedule some commands to run, gather the Pan output, and have them emailed weekly to me and my other partners running these sites. It would be great if we could add descriptive tags to each of the elements in the Pan output, so we can leave "notes" of sort about the element we're targeting.

I've been working on a POC on my own fork of what that change might look like, and didn't necessarily want to PR it before discussing if it makes sense to do for Pan. More than happy to keep my fork available and update as is, as I'd like to report analytics to non-technical folks that don't necessarily want to look at the slugified data attribute tags in the output and would rather have some sort of friendly description of the element.

An example output I've scapped together after all the work and what it would ultimately boil down to:

image

Thanks for all of your work @nunomaduro and @iamdavidhill!

@chrispage1
Copy link

I think this could be handy but maybe best suited to be similar to the existing whitelisting - https://github.com/panphp/pan?tab=readme-ov-file#whitelist-your-product-analytics

So you can define it as below rather than submitting the descriptions via JavaScript.

PanConfiguration::eventDescriptions([
  'tab-profile' => 'Profile tab on user landing page',
])

@chrispage1
Copy link

@JoeyMckenzie - I've written an implementation of this on server-side only. Of course means there is room for a JS implementation although I worry it might leave it a little bit exposed to exploitation

@JoeyMckenzie
Copy link
Author

JoeyMckenzie commented Nov 12, 2024

Yeah, I think that makes sense for the primary concern of keeping the description server-side. My take was more based in the Statamic websites I run, where I have a content manager that could provide the descriptions via blueprint text field or something, and that could be dropped right into an Antlers template. That way, they could modify the descriptions on the fly (though I didn't include any update logic in my POC yet).

I think it's a good idea to get this in in some form, and I think defaulting to server-side description is the safe bet initially.

@chrispage1
Copy link

chrispage1 commented Nov 12, 2024

Ah Statamic - how do you find it? I had a go with it but only made one website a while back - a little off topic - sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants