Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon invalidation for source code modifications #5046

Closed
kwlzn opened this issue Nov 2, 2017 · 5 comments
Closed

daemon invalidation for source code modifications #5046

kwlzn opened this issue Nov 2, 2017 · 5 comments
Milestone

Comments

@kwlzn
Copy link
Member

kwlzn commented Nov 2, 2017

after #5045 lands, it occurred to me that a simple strategy for invalidating the daemon on source code modification would be to fingerprint any relevant sources and then set the --version option implicitly in the pants wrapper with e.g. a suffixed sha. this should inherently provide for the appropriate restarts on source code modification while in development mode in the repo since the value of --version will be considered as part of the daemon's own fingerprint/lifecycle.

@kwlzn kwlzn added the pantsd label Nov 2, 2017
@kwlzn kwlzn added this to the Daemon Beta milestone Nov 2, 2017
@stuhood
Copy link
Member

stuhood commented Nov 9, 2017

cc @jsirois ... likely related to dogfooding of test caching as well.

@stuhood stuhood changed the title daemon invalidation for source code modifications in the pantsbuild/pants repo daemon invalidation for source code modifications Nov 26, 2017
@stuhood
Copy link
Member

stuhood commented Nov 26, 2017

@kwlzn : I've updated the title. I think that (although it's potentially expensive), a general solution here would be to fingerprint everything in the PYTHONPATH (which pants itself adds to in order to load loose-source plugins).

This would have the effect of fixing the issue for loose source plugins as well: see https://www.pantsbuild.org/howto_plugin.html#simple-configuration

@stuhood
Copy link
Member

stuhood commented Dec 5, 2017

I'm going to target this out of the beta, as it doesn't affect users.

@stuhood stuhood modified the milestones: Daemon Beta, 1.4.x Dec 5, 2017
@stuhood stuhood modified the milestones: 1.4.x, 1.5.x Jan 12, 2018
@stuhood stuhood added this to the 1.5.x milestone Feb 1, 2018
@stuhood
Copy link
Member

stuhood commented Feb 9, 2018

Mentioned in slack: this also affects loose source plugins in someone's repo.

@stuhood
Copy link
Member

stuhood commented Jun 15, 2018

Resolved. There is a followup in #5567 though.

@stuhood stuhood closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants