-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon invalidation for source code modifications #5046
Comments
cc @jsirois ... likely related to dogfooding of test caching as well. |
@kwlzn : I've updated the title. I think that (although it's potentially expensive), a general solution here would be to fingerprint everything in the This would have the effect of fixing the issue for loose source plugins as well: see https://www.pantsbuild.org/howto_plugin.html#simple-configuration |
I'm going to target this out of the beta, as it doesn't affect users. |
Mentioned in slack: this also affects loose source plugins in someone's repo. |
Resolved. There is a followup in #5567 though. |
after #5045 lands, it occurred to me that a simple strategy for invalidating the daemon on source code modification would be to fingerprint any relevant sources and then set the
--version
option implicitly in the pants wrapper with e.g. a suffixed sha. this should inherently provide for the appropriate restarts on source code modification while in development mode in the repo since the value of--version
will be considered as part of the daemon's own fingerprint/lifecycle.The text was updated successfully, but these errors were encountered: