You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #7073, we have to change sys.stderr to sys.stderr.buffer, along with changing print() to a .write() in order to write bytes to stderr. We need to do this elsewhere, noted in the comment linked above, and these are all on the pantsd/pantsd-runner logic path. We should:
validate that the stream we receive as an argument to ExceptionSink.reset_interactive_output_stream() is ready to receive bytes (e.g. changing sys.stderr to sys.stderr.buffer) this should actually be done with type hints, see Add type hints to codebase #6742
add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log in python 3 land
See #7220 for a discussion of related pantsd testing we really need to add sooner rather than later.
The text was updated successfully, but these errors were encountered:
cosmicexplorer
changed the title
validate interactive output stream in pantsd overrides ExceptionSink stream reset method if the stream is a binary buffer for py3
add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log
Jan 23, 2019
cosmicexplorer
changed the title
add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log
add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log in py3
Jan 23, 2019
See this comment on #7073.
In #7073, we have to change
sys.stderr
tosys.stderr.buffer
, along with changingprint()
to a.write()
in order to write bytes to stderr. We need to do this elsewhere, noted in the comment linked above, and these are all on the pantsd/pantsd-runner logic path. We should:ExceptionSink.reset_interactive_output_stream()
is ready to receive bytes (e.g. changingsys.stderr
tosys.stderr.buffer
) this should actually be done with type hints, see Add type hints to codebase #6742See #7220 for a discussion of related pantsd testing we really need to add sooner rather than later.
The text was updated successfully, but these errors were encountered: