Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log in py3 #7080

Closed
1 of 2 tasks
cosmicexplorer opened this issue Jan 14, 2019 · 1 comment

Comments

@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Jan 14, 2019

See this comment on #7073.

In #7073, we have to change sys.stderr to sys.stderr.buffer, along with changing print() to a .write() in order to write bytes to stderr. We need to do this elsewhere, noted in the comment linked above, and these are all on the pantsd/pantsd-runner logic path. We should:

  • validate that the stream we receive as an argument to ExceptionSink.reset_interactive_output_stream() is ready to receive bytes (e.g. changing sys.stderr to sys.stderr.buffer) this should actually be done with type hints, see Add type hints to codebase #6742
  • add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log in python 3 land

See #7220 for a discussion of related pantsd testing we really need to add sooner rather than later.

@cosmicexplorer cosmicexplorer changed the title validate interactive output stream in pantsd overrides ExceptionSink stream reset method if the stream is a binary buffer for py3 add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log Jan 23, 2019
@cosmicexplorer cosmicexplorer changed the title add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log add testing for the pantsd/pantsd-runner logic path to ensure we can write fatal exceptions to a log in py3 Jan 23, 2019
@stuhood
Copy link
Member

stuhood commented Apr 3, 2019

Possibly invalidated by #7390.

@stuhood stuhood closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants