Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Save a copy of the pantsd logs on clean-all and kill-pantsd #8128

Closed
blorente opened this issue Jul 30, 2019 · 1 comment
Closed

Comments

@blorente
Copy link
Contributor

Problem
When diagnosing pantsd issues, it's really hard to get accurate pantsd logs, because the first thing the user tries is ./pants clean-all, which removes anything of utility.

Solution
Store a pid-indexed copy of the pantsd logs either:

  • Whenever the daemon restarts, so on PantsDaemon.terminate().
  • Whenever we run a goal that would kill pantsd (./pants clean-all and ./pants kill-pantsd).

Result
Whenever we shutdown pantsd, a file like .pants.d/pantsd/pantsd.1234.log should be there after everything is said and done.

@blorente
Copy link
Contributor Author

Closing this as a duplicate of #8196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant