-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow vars_
and func_
in code actions to be configured
#106
Comments
I don't believe this was possible in LSP
I'm happy to keep this issue, and any other |
I'd be happy to consider any suggestions you may have here. I've considered this in the past, but specifying data for codeAction is not very straightforward. For example, "inline variable" doesn't need a new name, but "extract into variable" does. Additionally, because the LSP spec crams all code actions into LSP request / response, differences between code actions become really hard to handle without editor-specific logic |
microsoft/language-server-protocol#764, and microsoft/language-server-protocol#1164 So far as I can see the TLDR is that the protocol just doesn't support this yet, not even at 3.16. ( |
@pappasam I was thinking of using |
Currently code action provides random function and variable names when extracting. We want to use set it a constant value like
new_var
, ornew_func
, and let the users change the name as needed./cc @luabud
The text was updated successfully, but these errors were encountered: