Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder for NodeTypes::ChainSpec #10513

Closed
Tracked by #8904
emhane opened this issue Aug 25, 2024 · 1 comment
Closed
Tracked by #8904

Add builder for NodeTypes::ChainSpec #10513

emhane opened this issue Aug 25, 2024 · 1 comment
Assignees
@emhane
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain

Comments

@emhane
Copy link
Member

emhane commented Aug 25, 2024

Describe the feature

Add trait bound NodeTypes::ChainSpec: reth_node_api::BuilderProvider

Additional context

No response
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Aug 25, 2024
@emhane emhane self-assigned this Aug 25, 2024
@emhane emhane mentioned this issue Aug 25, 2024
Closed
@mattsse
Copy link
Collaborator

mattsse commented Sep 26, 2024

chainspec instantiation is done via CLI (parse by name or from file) this is already sufficiently abstracted

@mattsse mattsse closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emhane emhane

Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @emhane