Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused derives from alloy compat types #11199

Closed
Tracked by #12576
mattsse opened this issue Sep 25, 2024 · 1 comment
Closed
Tracked by #12576

remove unused derives from alloy compat types #11199

mattsse opened this issue Sep 25, 2024 · 1 comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 25, 2024

Describe the feature

these types are private and only used for conversions:

mod access_list;
mod authorization_list;
mod genesis_account;
mod header;
mod log;
mod request;
mod signature;
mod transaction;
mod trie;
mod txkind;
mod withdrawal;

we can reduce a lot of derives, some things are used for testing (serde I believe) so these should be cfg for test

TODO

  • remove unused derives and cfg things only used for testing (serde)

eg:

#[derive(Debug, Clone, PartialEq, Eq, Default, Serialize, Deserialize, Compact)]
#[cfg_attr(test, derive(arbitrary::Arbitrary))]
#[add_arbitrary_tests(compact)]
struct Withdrawal {

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 25, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Sep 25, 2024
@greged93
Copy link
Contributor

I think this can be closed no?

@mattsse mattsse closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

2 participants