Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for disabling read tx timeout on BlockchainProvider #11760

Closed
Tracked by #11672
Rjected opened this issue Oct 15, 2024 · 5 comments
Closed
Tracked by #11672

Add flag for disabling read tx timeout on BlockchainProvider #11760

Rjected opened this issue Oct 15, 2024 · 5 comments
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-enhancement New feature or request

Comments

@Rjected
Copy link
Member

Rjected commented Oct 15, 2024

We need a flag on the legacy blockchain provider that will disable the database transaction timeout whenever a transaction is created. This should cause it to call the disable_long_read_transaction_safety method whenever new db providers are created, like we do for state root in the old engine:

.disable_long_read_transaction_safety();

This should allow long running RPCs to be called without timing out when the legacy engine is used.

@Rjected Rjected added C-enhancement New feature or request A-db Related to the database A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Oct 15, 2024
@mattsse
Copy link
Collaborator

mattsse commented Oct 15, 2024

I assume this should only affect the StateProviders?

@Rjected
Copy link
Member Author

Rjected commented Oct 15, 2024

I assume this should only affect the StateProviders?

If possible, yes

@mattsse
Copy link
Collaborator

mattsse commented Oct 16, 2024

I think we can solve this with a function on StateProvider?

@Rjected
Copy link
Member Author

Rjected commented Oct 17, 2024

I think we can solve this with a function on StateProvider?

It would be fine if we did that on the state provider structs, but all the ProviderFactory methods that return state providers, return StateProviderBox

@Rjected
Copy link
Member Author

Rjected commented Oct 24, 2024

fixed by #11856

@Rjected Rjected closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-enhancement New feature or request
Projects
Archived in project
2 participants