Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce helper type for two BlockHashes #12493

Closed
mattsse opened this issue Nov 13, 2024 · 0 comments · Fixed by #12514
Closed

Introduce helper type for two BlockHashes #12493

mattsse opened this issue Nov 13, 2024 · 0 comments · Fixed by #12514
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2024

Describe the feature

currently we use an header when we actually only need the number+hash+parenthash

for example:

with upcoming generics, this would be harder to manage and we can use a new type, like

pub struct BlockAndParent {
  parent: Hash,
  block: BlockNumHash,
}

name tbd

TODO

  • introduce the type (can be in reth-primitives-traits first, but we want to move this to alloy later)

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant