Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eth/68 #1326

Closed
gakonst opened this issue Feb 14, 2023 · 2 comments · Fixed by #1361
Closed

Support eth/68 #1326

gakonst opened this issue Feb 14, 2023 · 2 comments · Fixed by #1361
Assignees
@jinsankim
Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@gakonst
Copy link
Member

gakonst commented Feb 14, 2023

Describe the feature

We're missing the eth/68 protocol implementation.

  1. Spec: https://eips.ethereum.org/EIPS/eip-5793
  2. Geth PR eth: implement eth/68 to support only announcing certain tx types ethereum/go-ethereum#25980

Additional context

No response
@gakonst gakonst added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-needs-triage This issue needs to be labelled A-devp2p Related to the Ethereum P2P protocol and removed S-needs-triage This issue needs to be labelled labels Feb 14, 2023
@jinsankim
Copy link
Contributor

I'd like to take this on.

@gakonst
Copy link
Member Author

gakonst commented Feb 14, 2023

Go for it. (cc @rkrasiuk would like you to review this work, should be simple and get you some visibility on the p2p code)

@onbjerg onbjerg moved this from Todo to In Progress in Reth Tracker Feb 14, 2023
@jinsankim jinsankim mentioned this issue Feb 15, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinsankim jinsankim

Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(net): support eth/68 jinsankim/reth
2 participants
@jinsankim @gakonst