Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HashedPostState into trie-common crate #14208

Closed
emhane opened this issue Feb 4, 2025 · 0 comments · Fixed by #14230
Closed

Move HashedPostState into trie-common crate #14208

emhane opened this issue Feb 4, 2025 · 0 comments · Fixed by #14230
Labels
A-dependencies Pull requests or issues that are about dependencies A-trie Related to Merkle Patricia Trie implementation D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Feb 4, 2025 •
edited by mattsse
Loading

this type doesn't depend on any reth-trie types

reth/crates/trie/trie/src/state.rs

Line 19 in f43cf9c

pub struct HashedPostState {

we can easily move this to trie-common crate

TODO

  • move type state.rs to trie-common crate
@emhane emhane added A-dependencies Pull requests or issues that are about dependencies A-trie Related to Merkle Patricia Trie implementation labels Feb 4, 2025
@emhane emhane added the D-good-first-issue Nice and easy! A great choice to get started label Feb 4, 2025
@mattsse mattsse removed the D-good-first-issue Nice and easy! A great choice to get started label Feb 4, 2025
@mattsse mattsse mentioned this issue Feb 4, 2025
Closed
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Feb 4, 2025
@mattsse mattsse changed the title Move trie types into no_std compatible reth-trie-common Move HashedPostState into trie-common crate Feb 4, 2025
@VeerChaurasia VeerChaurasia mentioned this issue Feb 4, 2025
Closed
@PoulavBhowmick03 PoulavBhowmick03 mentioned this issue Feb 5, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 6, 2025
@emhane emhane mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies A-trie Related to Merkle Patricia Trie implementation D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
2 participants
@mattsse @emhane