Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compilation fails: error: could not compile crunchy #14337

Closed
emhane opened this issue Feb 8, 2025 · 1 comment
Closed

Windows compilation fails: error: could not compile crunchy #14337

emhane opened this issue Feb 8, 2025 · 1 comment
Labels
A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-bug An unexpected or incorrect behavior O-windows OS: Windows

Comments

@emhane
Copy link
Member

emhane commented Feb 8, 2025

Describe the feature

Run cargo check -p op-reth --features optimism --target x86_64-pc-windows-gnu
##[debug]/usr/bin/bash -e /home/runner/work/_temp/0f66cff3-97bf-49f7-ba77-0ea31bbea117.sh
    Checking crunchy v0.2.3
    Checking blst v0.3.13
   Compiling c-kzg v1.0.3
    Checking secp256k1-sys v0.10.1
   Compiling alloy-sol-macro-expander v0.8.20
error: couldn't read /home/runner/work/reth/reth/target/x86_64-pc-windows-gnu/debug/build/crunchy-1554ab1beea9569d/out\lib.rs: No such file or directory (os error 2)
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crunchy-0.2.3/src/lib.rs:37:1
   |
37 | include!(concat!(env!("OUT_DIR"), "\\lib.rs"));
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `crunchy` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.
##[debug]Finishing: Check OP-Reth

Additional context

https://github.com/paradigmxyz/reth/actions/runs/13218883835/job/36901544900
https://github.com/paradigmxyz/reth/actions/runs/13218883835/job/36901544801

@emhane emhane added A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-bug An unexpected or incorrect behavior O-windows OS: Windows labels Feb 8, 2025
@emhane
Copy link
Member Author

emhane commented Feb 9, 2025

fixed by forcing use of crunchy version locked in workspace manifest by adding dependency to crate directly and adding

#[cfg_attr(target_os = "windows", allow(unused_imports))]
use crunchy as _;

to crate root

@emhane emhane closed this as completed Feb 9, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Related to github workflows or other build and lint tools A-dependencies Pull requests or issues that are about dependencies C-bug An unexpected or incorrect behavior O-windows OS: Windows
Projects
Archived in project
Development

No branches or pull requests

1 participant